Browse files

request-pull: improve error message for invalid revision args

Currently, when an invalid revision is specified, the error message is:

    fatal: Needed a single revision

This is misleading because, you might think there is something wrong
with the command line as a whole.

Now the user gets a more meaningful error message, showing the invalid

Signed-off-by: Dirk Wallenstein <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent 239222f commit ace33bf991f8f6643e58a3642962ed244ba36b5b @dirkwallenstein dirkwallenstein committed with gitster Jul 17, 2013
Showing with 12 additions and 2 deletions.
  1. +12 −2
@@ -51,8 +51,18 @@ fi
tag_name=$(git describe --exact "$head^0" 2>/dev/null)
test -n "$base" && test -n "$url" || usage
-baserev=$(git rev-parse --verify "$base"^0) &&
-headrev=$(git rev-parse --verify "$head"^0) || exit
+baserev=$(git rev-parse --verify --quiet "$base"^0)
+if test -z "$baserev"
+ die "fatal: Not a valid revision: $base"
+headrev=$(git rev-parse --verify --quiet "$head"^0)
+if test -z "$headrev"
+ die "fatal: Not a valid revision: $head"
merge_base=$(git merge-base $baserev $headrev) ||
die "fatal: No commits in common between $base and $head"

0 comments on commit ace33bf

Please sign in to comment.