Browse files

vcs-svn: suppress a signed/unsigned comparison warning

The preceding code checks that view->max_off is nonnegative and
(off + width) fits in an off_t, so this code is already safe.

Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
  • Loading branch information...
1 parent 6a0b443 commit c68038effed2f1031848330cca46e85fc79e3ab2 @barrbrain barrbrain committed with jrn Jun 1, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 vcs-svn/sliding_window.c
View
2 vcs-svn/sliding_window.c
@@ -54,7 +54,7 @@ int move_window(struct sliding_view *view, off_t off, size_t width)
return -1;
if (off < view->off || off + width < view->off + view->width)
return error("invalid delta: window slides left");
- if (view->max_off >= 0 && view->max_off < off + width)
+ if (view->max_off >= 0 && view->max_off < off + (off_t) width)
return error("delta preimage ends early");
file_offset = view->off + view->buf.len;

0 comments on commit c68038e

Please sign in to comment.