Browse files

unquote_c_style: fix off-by-one.

The optional endp parameter to unquote_c_style() was supposed to point at
a location past the closing double quote, but it was going one beyond it.

git-fast-import used this function heavily and the bug caused it to
misparse the input stream, especially when parsing a rename command:

	R "filename that needs quoting" rename-target-name

Because the function erroneously ate the whitespace after the closing dq,
this triggered "Missing space after source" error when it shouldn't.

Thanks to Adeodato Simò for having caught this.

Signed-off-by: Pierre Habouzit <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent c2116a1 commit c8744d6a8b27115503565041566d97c21e722584 @MadCoder MadCoder committed with gitster Mar 6, 2008
Showing with 1 addition and 1 deletion.
  1. +1 −1 quote.c
2 quote.c
@@ -288,7 +288,7 @@ int unquote_c_style(struct strbuf *sb, const char *quoted, const char **endp)
switch (*quoted++) {
case '"':
if (endp)
- *endp = quoted + 1;
+ *endp = quoted;
return 0;
case '\\':

0 comments on commit c8744d6

Please sign in to comment.