Browse files

sparse: Fix an "symbol 'format_subject' not declared" warning

In order to fix the warning, we add an extern declaration for this
function to the "commit.h" header file, along with all other non-
static functions defined in pretty.c. Also, we remove the function
declaration from builtin/shortlog.c, since it is no longer needed.

Signed-off-by: Ramsay Jones <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent d27da38 commit c8f1444d9e708e3994c74c180194c43bf1588b65 Ramsay Jones committed with gitster Apr 7, 2011
Showing with 2 additions and 3 deletions.
  1. +0 −3 builtin/shortlog.c
  2. +2 −0 commit.h
@@ -29,9 +29,6 @@ static int compare_by_number(const void *a1, const void *a2)
return -1;
-const char *format_subject(struct strbuf *sb, const char *msg,
- const char *line_separator);
static void insert_one_record(struct shortlog *log,
const char *author,
const char *oneline)
@@ -90,6 +90,8 @@ extern char *logmsg_reencode(const struct commit *commit,
extern char *reencode_commit_message(const struct commit *commit,
const char **encoding_p);
extern void get_commit_format(const char *arg, struct rev_info *);
+extern const char *format_subject(struct strbuf *sb, const char *msg,
+ const char *line_separator);
extern void userformat_find_requirements(const char *fmt, struct userformat_want *w);
extern void format_commit_message(const struct commit *commit,
const char *format, struct strbuf *sb,

0 comments on commit c8f1444

Please sign in to comment.