Browse files

add--interactive: fix external command invocation on Windows

Back in 21e9757 (Hack git-add--interactive to make it work with
ActiveState Perl, 2007-08-01), the invocation of external commands was
changed to use qx{} on Windows. The rationale was that the command
interpreter on Windows is not a POSIX shell, but rather Windows's CMD.
That patch was wrong to include 'msys' in the check whether to use qx{}
or not: 'msys' identifies MSYS perl as shipped with Git for Windows,
which does not need the special treatment; qx{} should be used only with
ActiveState perl, which is identified by 'MSWin32'.

Signed-off-by: Johannes Sixt <>
Signed-off-by: Junio C Hamano <>
  • Loading branch information...
1 parent e230c56 commit df17e77c0aacca35eaaac885fe70d97654c07d62 @j6t j6t committed with gitster Sep 4, 2013
Showing with 1 addition and 1 deletion.
  1. +1 −1 git-add--interactive.perl
@@ -169,7 +169,7 @@ sub colored {
my %patch_mode_flavour = %{$patch_modes{stage}};
sub run_cmd_pipe {
- if ($^O eq 'MSWin32' || $^O eq 'msys') {
+ if ($^O eq 'MSWin32') {
my @invalid = grep {m/[":*]/} @_;
die "$^O does not support: @invalid\n" if @invalid;
my @args = map { m/ /o ? "\"$_\"": $_ } @_;

0 comments on commit df17e77

Please sign in to comment.