Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Feb 11, 2009

  1. Stephan Beyer

    Generalize and libify index_is_dirty() to index_differs_from(...)

    index_is_dirty() in builtin-revert.c checks if the index is dirty.
    This patch generalizes this function to check if the index differs
    from a revision, i.e. the former index_is_dirty() behavior can now be
    achieved by index_differs_from("HEAD", 0).
    
    The second argument "diff_flags" allows to set further diff option
    flags like DIFF_OPT_IGNORE_SUBMODULES. See DIFF_OPT_* macros in diff.h
    for a list.
    
    index_differs_from() seems to be useful for more than builtin-revert.c,
    so it is moved into diff-lib.c and also used in builtin-commit.c.
    
    Yet to mention:
    
     - "rev.abbrev = 0;" can be safely removed.
       This has no impact on performance or functioning of neither
       setup_revisions() nor run_diff_index().
    
     - rev.pending.objects is free()d because this fixes a leak.
       (Also see 295dd2a "Fix memory leak in traverse_commit_list")
    
    Mentored-by: Daniel Barkalow <barkalow@iabervon.org>
    Mentored-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    authored February 10, 2009 gitster committed February 10, 2009
Something went wrong with that request. Please try again.