Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 3, 2012
  1. @trast @gitster

    diff_setup_done(): return void

    trast authored gitster committed
    diff_setup_done() has historically returned an error code, but lost
    the last nonzero return in 943d5b7 (allow diff.renamelimit to be set
    regardless of -M/-C, 2006-08-09).  The callers were in a pretty
    confused state: some actually checked for the return code, and some
    did not.
    
    Let it return void, and patch all callers to take this into account.
    This conveniently also gets rid of a handful of different(!) error
    messages that could never be triggered anyway.
    
    Note that the function can still die().
    
    Signed-off-by: Thomas Rast <trast@student.ethz.ch>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jan 7, 2009
  1. @trast @gitster

    diff --no-index -q: fix endless loop

    trast authored gitster committed
    We forgot to move to the next argument when parsing -q, getting stuck
    in an endless loop.
    
    Signed-off-by: Thomas Rast <trast@student.ethz.ch>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @trast @gitster

    diff --no-index: test for pager after option parsing

    trast authored gitster committed
    We need to parse options before we can see if --exit-code was
    provided.
    
    Signed-off-by: Thomas Rast <trast@student.ethz.ch>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  3. @trast @gitster

    diff: accept -- when using --no-index

    trast authored gitster committed
    Accept -- as an "end of options" marker even when using --no-index.
    Previously, the -- triggered a "normal" index/tree diff and subsequently
    failed because of the unrecognized (in that mode) --no-index.
    
    Note that the second loop can treat '--' as a normal option, because
    the preceding checks ensure it is the third-to-last argument.
    
    While at it, fix the parsing of "-q" option in --no-index mode as well.
    
    Signed-off-by: Thomas Rast <trast@student.ethz.ch>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Something went wrong with that request. Please try again.