Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 23, 2014
  1. @devzero2000 @gitster

    git-web--browse.sh: use the $( ... ) construct for command substitution

    devzero2000 authored gitster committed
    The Git CodingGuidelines prefer the $(...) construct for command
    substitution instead of using the backquotes `...`.
    
    The backquoted form is the traditional method for command
    substitution, and is supported by POSIX.  However, all but the
    simplest uses become complicated quickly.  In particular, embedded
    command substitutions and/or the use of double quotes require
    careful escaping with the backslash character.
    
    The patch was generated by:
    
    for _f in $(find . -name "*.sh")
    do
       sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
    done
    
    and then carefully proof-read.
    
    Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
    Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Oct 30, 2013
  1. @ruediger @gitster

    web--browse: Add support for xdg-open

    ruediger authored gitster committed
    xdg-open is a tool similar to git-web--browse.  It opens a file or URL in the
    user's preferred application.  It could probably be made default at least on
    Linux with a graphical environment.
    
    Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jun 21, 2013
  1. @gitster

    web--browse: support /usr/bin/cygstart on Cygwin

    Yaakov Selkowitz authored gitster committed
    While both GUI and console Cygwin browsers do exist, anecdotal evidence
    suggests most users rely on their native Windows browser.  cygstart,
    which is a long-standing part of the base Cygwin installation, will
    cause the page to be opened in the default Windows browser (the one
    registered to open .html files).
    
    Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Mar 29, 2013
  1. @jszakmeister @gitster

    git-web--browse: recognize any TERM_PROGRAM as a GUI terminal on OS X

    jszakmeister authored gitster committed
    It turns out that the presence of SECURITYSESSIONID is not sufficient
    for detecting the presence of a GUI under Mac OS X.  SECURITYSESSIONID
    appears to only be set when the user has Screen Sharing enabled.
    Disabling Screen Sharing and relaunching the shell showed that the
    variable was missing, at least under Mac OS X 10.6.8.
    
    On the other hand, TERM_PROGRAM seems to be set for any terminals on
    OS X, so just check it is set to something, instead of hardcoding
    "Apple_Terminal" and missing other terminals such as iTerm.app.
    
    Signed-off-by: John Szakmeister <john@szakmeister.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Oct 3, 2011
  1. @cpackham @gitster

    git-web--browse: avoid the use of eval

    cpackham authored gitster committed
    Using eval causes problems when the URL contains an appropriately
    escaped ampersand (\&). Dropping eval from the built-in browser
    invocation avoids the problem.
    
    Helped-by: Jeff King <peff@peff.net> (test case)
    Signed-off-by: Chris Packham <judge.packham@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Dec 3, 2010
  1. @Oblomov @gitster

    web--browse: better support for chromium

    Oblomov authored gitster committed
    On Debian-based distributions, Chromium the browser is available under
    the name chromium-browser rather than chromium, to prevent conflicts
    with the Chromium B.S.U. game.
    
    Look for chromium-browser first when setting the path for chromium, and
    also add chromium-browser as a supported browser name. Document the
    dual-name support, and mention the dual-name support for
    (google-)chrome too.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @Oblomov @gitster

    web--browse: support opera, seamonkey and elinks

    Oblomov authored gitster committed
    The list of supported browsers is also updated in the documentation.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  3. @Oblomov @gitster

    web--browse: split valid_tool list

    Oblomov authored gitster committed
    It was getting too long, and we want to add some more.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  4. @Oblomov @gitster

    web--browse: coding style

    Oblomov authored gitster committed
    Retab and deindent choices in case statements.
    
    Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jul 26, 2010
  1. @panike @gitster

    Add a google-chrome option for web--browse

    panike authored gitster committed
    On some systems, the chrome browser is named google-chrome.  We add
    support for this case.
    
    Signed-off-by: Nathan W. Panike <nathan.panike@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jun 1, 2010
  1. @pksunkara @gitster

    git-web--browse: Add support for google chrome and chromium

    pksunkara authored gitster committed
    Add support for google's chrome & chromium. The value of the
    browser is 'chromium' or 'chrome' to select it.
    
    You can always provide config variable for browser path if they
    are not installed in right paths.
    
    Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Sep 14, 2009
  1. @gitster

    web--browse: fix Mac OS X GUI detection for 10.6

    Heiko Voigt authored gitster committed
    Since OS X 10.6 the variable $SECURITYSESSIONID does not exist anymore,
    so lets look for the $TERM_PROGRAM variable as backup.
    
    Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jun 1, 2009
  1. @patthoyts @gitster

    git: browsing paths with spaces when using the start command

    patthoyts authored gitster committed
    msysGit issue 258 tracks a problem opening a browser onto file
    paths that contain spaces or parentheses when calling the
    web--browse script. This patch modifies how the start command is
    called to solve this.
    
    Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
    Signed-off-by: Steffen Prohaska <prohaska@zib.de>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Feb 9, 2009
  1. @tmzullinger @gitster

    git-web--browse: Fix check for /bin/start

    tmzullinger authored gitster committed
    The previous check in git-web--browse for /bin/start used test -n
    /bin/start, which was always true.  This lead to "start" being tried
    first in the browser list.  On systems with upstart installed, "start"
    exists and might be in the PATH, but it makes a poor choice for a web
    browser.  Instead, test that /bin/start exists and is executable.
    
    Signed-off-by: Todd Zullinger <tmz@pobox.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Sep 24, 2008
  1. @spearce

    git-web--browse: Support for using /bin/start on MinGW

    Petr Baudis authored spearce committed
    In the future, I think we should also default to xdg-open on Linux instead
    of having a KDE-specific hack.
    
    This patch has been sponsored by Novartis.
    
    Signed-off-by: Petr Baudis <pasky@suse.cz>
    Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Commits on Mar 14, 2008
  1. @chriscool @gitster

    web--browse: use custom commands defined at config time

    chriscool authored gitster committed
    Currently "git web--browse" is restricted to a set of commands defined
    in the script. You can subvert the "browser.<tool>.path" to force "git
    web--browse" to use a different command, but if you have a command
    whose invocation syntax does not match one of the current tools then
    you would have to write a wrapper script for it.
    
    This patch adds a git config variable "browser.<tool>.cmd" which
    allows a more flexible browser choice.
    
    If you run "git web--browse" with -t/--tool, -b/--browser or the
    "web.browser" config variable set to an unrecognized tool then "git
    web--browse" will query the "browser.<tool>.cmd" config variable. If
    this variable exists, then "git web--browse" will treat the specified
    tool as a custom command and will use a shell eval to run the command
    with the URLs added as extra parameters.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Feb 17, 2008
  1. @gitster

    Merge branch 'cc/browser'

    gitster authored
    * cc/browser:
      Documentation: add 'git-web--browse.txt' and simplify other docs.
      git-web--browse: fix misplaced quote in init_browser_path()
      web--browse: Add a few quotes in 'init_browser_path'.
      Documentation: instaweb: add 'git-web--browse' information.
      Adjust .gitignore for 5884f1(Rename 'git-help--browse.sh'...)
      git-web--browse: do not start the browser with nohup
      instaweb: use 'git-web--browse' to launch browser.
      Rename 'git-help--browse.sh' to 'git-web--browse.sh'.
      help--browse: add '--config' option to check a config option for a browser.
      help: make 'git-help--browse' usable outside 'git-help'.
    
    Conflicts:
    
    	git-web--browse.sh
Commits on Feb 11, 2008
  1. @gitster

    git-web--browse: fix misplaced quote in init_browser_path()

    jaysoffian+git@gmail.com authored gitster committed
    git "config browser.$1.path" should be git config "browser.$1.path"
    
    Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Feb 10, 2008
  1. @chriscool @gitster

    web--browse: Add a few quotes in 'init_browser_path'.

    chriscool authored gitster committed
    These changes were made to the 'init_browser_path' function in
    'git-instaweb.sh', but was not in 'git-web--browse.sh'.
    
    [jc: the quoting was screwy and did not quote $1 correctly, so
     I fixed it up.]
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @dmpot @gitster

    git-web--browse: do not start the browser with nohup

    dmpot authored gitster committed
    There is no good reason to run GUI browsers using "nohup". It does not
    solve any real problem but creates annoying "nohup.out" files in every
    directory where git help -w is run.
    
    Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Feb 5, 2008
  1. @chriscool @gitster

    Rename 'git-help--browse.sh' to 'git-web--browse.sh'.

    chriscool authored gitster committed
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Something went wrong with that request. Please try again.