Skip to content
Commits on Apr 30, 2009
  1. @raalkml @gitster

    replace direct calls to unlink(2) with unlink_or_warn

    raalkml committed with gitster
    This helps to notice when something's going wrong, especially on
    systems which lock open files.
    I used the following criteria when selecting the code for replacement:
    - it was already printing a warning for the unlink failures
    - it is in a function which already printing something or is
      called from such a function
    - it is in a static function, returning void and the function is only
      called from a builtin main function (cmd_)
    - it is in a function which handles emergency exit (signal handlers)
    - it is in a function which is obvously cleaning up the lockfiles
    Signed-off-by: Alex Riesen <>
    Signed-off-by: Junio C Hamano <>
Something went wrong with that request. Please try again.