Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 17, 2007
  1. @torvalds

    Clean up object creation to use more common code

    torvalds authored Junio C Hamano committed
    This replaces the fairly odd "created_object()" function that did _most_
    of the object setup with a more complete "create_object()" function that
    also has a more natural calling convention.
    
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Junio C Hamano <junkio@cox.net>
  2. @torvalds

    Use proper object allocators for unknown object nodes too

    torvalds authored Junio C Hamano committed
    We used to use a different allocator scheme for when we didn't know the
    object type.  That meant that objects that were created without any
    up-front knowledge of the type would not go through the same allocation
    paths as normal object allocations, and would miss out on the statistics.
    
    But perhaps more importantly than the statistics (that are useful when
    looking at memory usage but not much else), if we want to make the
    object hash tables use a denser object pointer representation, we need
    to make sure that they all go through the same blocking allocator.
    
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Junio C Hamano <junkio@cox.net>
Commits on Mar 21, 2007
  1. @torvalds

    Don't ever return corrupt objects from "parse_object()"

    torvalds authored Junio C Hamano committed
    Looking at the SHA1 validation code due to the corruption that Alexander
    Litvinov is seeing under Cygwin, I notice that one of the most central
    places where we read objects, we actually do end up verifying the SHA1 of
    the result, but then we happily parse it anyway.
    
    And using "printf" to write the error message means that it not only can
    get lost, but will actually mess up stdout, and cause other strange and
    hard-to-debug failures downstream.
    
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Junio C Hamano <junkio@cox.net>
Something went wrong with that request. Please try again.