Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Jul 26, 2010

  1. trast

    Do not unquote + into ' ' in URLs

    Since 9d2e942 (decode file:// and ssh:// URLs, 2010-05-23) the URL
    logic unquotes escaped URLs.  For the %2B type of escape, this is
    conformant with RFC 2396.  However, it also unquotes + into a space
    character, which is only appropriate for the query strings in HTTP.
    This notably broke fetching from the gtk+ repository.
    
    We cannot just remove the corresponding code since the same
    url_decode_internal() is also used by the HTTP backend to decode query
    parameters.  Introduce a new argument that controls whether the +
    decoding happens, and use it only in the (client-side) url_decode().
    
    Reported-by: Jasper St. Pierre <jstpierre@mecheye.net>
    Signed-off-by: Thomas Rast <trast@student.ethz.ch>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    authored July 24, 2010 gitster committed July 25, 2010
Something went wrong with that request. Please try again.