Skip to content
Commits on Aug 11, 2011
  1. @drizzd @gitster

    ls-files: fix pathspec display on error

    drizzd committed with gitster Aug 1, 2011
    The following sequence of commands reveals an issue with error
    reporting of relative paths:
    
     $ mkdir sub
     $ cd sub
     $ git ls-files --error-unmatch ../bbbbb
     error: pathspec 'b' did not match any file(s) known to git.
     $ git commit --error-unmatch ../bbbbb
     error: pathspec 'b' did not match any file(s) known to git.
    
    This bug is visible only if the normalized path (i.e., the relative
    path from the repository root) is longer than the prefix.
    Otherwise, the code skips over the normalized path and reads from
    an unused memory location which still contains a leftover of the
    original command line argument.
    
    So instead, use the existing facilities to deal with relative paths
    correctly.
    
    Also fix inconsistency between "checkout" and "commit", e.g.
    
        $ cd Documentation
        $ git checkout nosuch.txt
        error: pathspec 'Documentation/nosuch.txt' did not match...
        $ git commit nosuch.txt
        error: pathspec 'nosuch.txt' did not match...
    
    by propagating the prefix down the codepath that reports the error.
    
    Signed-off-by: Clemens Buchacher <drizzd@aon.at>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jun 5, 2010
  1. @drizzd @gitster

    quote.c: separate quoting and relative path generation

    drizzd committed with gitster Jun 3, 2010
    This is in preparation of relative path support for ls-files, which
    quotes a path only if the line terminator is not the NUL character.
    
    Signed-off-by: Clemens Buchacher <drizzd@aon.at>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Something went wrong with that request. Please try again.