Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
base: 02d263277ab827a1a77cbb6f3c703e8b7181efde
Choose a base ref
...
head repository: git/git
compare: ccdd5d1eb14a6735c34428e856c0de33f1055520
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 31, 2021

  1. mailmap.c: fix a memory leak in free_mailap_{info,entry}() 

    In the free_mailmap_entry() code added in 0925ce4 (Add map_user()
and clear_mailmap() to mailmap, 2009-02-08) the intent was clearly to
clear the "me" structure, but while we freed parts of the
mailmap_entry structure, we didn't free the structure itself. The same
goes for the "mailmap_info" structure.

This brings the number of SANITIZE=leak failures in t4203-mailmap.sh
down from 50 to 49. Not really progress as far as the number of
failures is concerned, but as far as I can tell this fixes all leaks
in mailmap.c itself. There's still users of it such as builtin/log.c
that call read_mailmap() without a clear_mailmap(), but that's on
them.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @avar @gitster
    avar authored and gitster committed Aug 31, 2021
    Copy the full SHA
    ccdd5d1 View commit details
    Browse the repository at this point in the history