Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
base: 1396a95ee0a1d4853139e896114020409c506e52
Choose a base ref
...
head repository: git/git
compare: 88682b016dcbdbbdebdd2efd9b7de63e4395636f
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 31, 2021

  1. protocol-caps.c: fix memory leak in send_info() 

    Fix a memory leak in a2ba162 (object-info: support for retrieving
object info, 2021-04-20) which appears to have been based on a
misunderstanding of how the pkt-line.c API works. There is no need to
strdup() input to packet_writer_write(), it's just a printf()-like
format function.

This fixes a potentially large memory leak, since the number of OID
lines the "object-info" call can be arbitrarily large (or a small one
if the request is small).

This makes t5701-git-serve.sh pass again under SANITIZE=leak, as it
did before a2ba162.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Acked-by: Bruno Albuquerque <bga@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
    @avar @gitster
    avar authored and gitster committed Aug 31, 2021
    Copy the full SHA
    88682b0 View commit details
    Browse the repository at this point in the history