Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: git/git
base: 65ca3245f99e3595ac483e4af5b2ff34b7985635
Choose a base ref
...
head repository: git/git
compare: 7ff24785cb7e1655f1295dce3e0269348bbbbe02
Choose a head ref
  • 10 commits
  • 80 files changed
  • 2 contributors

Commits on Oct 7, 2021

  1. Merge branch 'ab/sanitize-leak-ci' into ab/mark-leak-free-tests

    * ab/sanitize-leak-ci:
      tests: add a test mode for SANITIZE=leak, run it in CI
      Makefile: add SANITIZE=leak flag to GIT-BUILD-OPTIONS
    gitster committed Oct 7, 2021
    Copy the full SHA
    25dc57b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. leak tests: run various built-in tests in t00*.sh SANITIZE=leak

    Mark various existing tests in t00*.sh that invoke git built-ins with
    TEST_PASSES_SANITIZE_LEAK=true as passing when git is compiled with
    SANITIZE=leak.
    
    They'll now be listed as running under the
    "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks" CI
    target).
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    c150064 View commit details
    Browse the repository at this point in the history
  2. leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leak

    Mark various existing tests in t00*.sh that invoke a "test-tool" with
    as passing when git is compiled with SANITIZE=leak.
    
    They'll now be listed as running under the
    "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks" CI
    target).
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    fdc8f79 View commit details
    Browse the repository at this point in the history
  3. leak tests: mark all ls-tree tests as passing with SANITIZE=leak

    Mark those tests that match "*ls-tree*" as passing when git is
    compiled with SANITIZE=leak. They'll now be listed as running under
    the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks"
    CI target).
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    809aeed View commit details
    Browse the repository at this point in the history
  4. leak tests: mark all trace2 tests as passing with SANITIZE=leak

    Mark all tests that match "*trace2*" as passing when git is compiled
    with SANITIZE=leak. They'll now be listed as running under the
    "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks" CI
    target).
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    0033ab3 View commit details
    Browse the repository at this point in the history
  5. leak tests: mark all checkout-index tests as passing with SANITIZE=leak

    Mark some tests that match "*{checkout,switch}*" as passing when git
    is compiled with SANITIZE=leak. They'll now be listed as running under
    the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks"
    CI target).
    
    Unfortunately almost all of those tests fail when compiled with
    SANITIZE=leak, these only pass because they run "checkout-index", not
    the main "checkout" command.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    b7bcdbd View commit details
    Browse the repository at this point in the history
  6. leak tests: mark some ls-files tests as passing with SANITIZE=leak

    Mark some tests that match "*ls-files*" as passing when git is
    compiled with SANITIZE=leak. They'll now be listed as running under
    the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks"
    CI target). We still have others that match '*ls-files*" that fail
    under SANITIZE=leak.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    0b3481c View commit details
    Browse the repository at this point in the history
  7. leak tests: mark some read-tree tests as passing with SANITIZE=leak

    Mark some tests that match "*read-tree*" as passing when git is
    compiled with SANITIZE=leak. They'll now be listed as running under
    the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test mode (the "linux-leaks"
    CI target). We still have around half the tests that match
    "*read-tree*" failing, but let's whitelist those that don't.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    98300c8 View commit details
    Browse the repository at this point in the history
  8. leak tests: mark various "generic" tests as passing with SANITIZE=leak

    Mark various "generic" tests as passing when git is compiled with
    SANITIZE=leak. These tests were subjectively picked from the lists of
    passing tests since they're all small, and test some generic feature
    such as wildmatch(), commonly used environment variables, ident
    parsing etc.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    288a480 View commit details
    Browse the repository at this point in the history
  9. leak tests: mark some misc tests as passing with SANITIZE=leak

    Mark some tests that match "*{mktree,commit,diff,grep,rm,merge,hunk}*"
    as passing when git is compiled with SANITIZE=leak. They'll now be
    listed as running under the "GIT_TEST_PASSING_SANITIZE_LEAK=true" test
    mode (the "linux-leaks" CI target).
    
    These were picked because we still have a lot of failures in adjacent
    areas, and we didn't have much if any coverage of e.g. grep and diff
    before this change, we could still whitelist a lot more tests, but
    let's stop for now.
    
    Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
    avar authored and gitster committed Oct 13, 2021
    Copy the full SHA
    7ff2478 View commit details
    Browse the repository at this point in the history