git-p4: add config to charset p4 commands #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perforce keeps the encoding of a submit log message as given on set P4CHARSET. If this encoding is not utf-8, most Git GUI Clients will not be able to display the log messages. Add a string Git config value `git-p4.charset` to define the encoding. This value is used to transcode the log messages to UTF-8.
|
Thank you for contributing this patch! I cannot review it as my Perforce background is too weak, but you can send the patch to the Git mailing list for review (as suggested in the PR description template), either via GitGitGadget, submitGit or manually. Do make sure that your commit message is wrapped to <=76 columns/line, and to add your sign off before you do so, though. |
|
@yonmy ping? |
pong. |
|
@yonmy ping? |
|
@yonmy gentle ping? |
|
pong, I am sorry. |
|
@yonmy would you still want to contribute the patch? If so, please use one of the advised routes to the Git mailing list. Otherwise, please close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perforce keeps the encoding of a submit log message as given on set P4CHARSET.
If this encoding is not utf-8, most Git GUI Clients will not be able to display the log messages.
Add a string Git config value
git-p4.charsetto define the encoding. This value is used to transcode the log messages to UTF-8.Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list (git@vger.kernel.org) for code submissions, code reviews, and
bug reports. Nevertheless, you can use submitGit to conveniently send your Pull
Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!