Team was created with error message "Failed to add team!"

[gitblit]

Originally reported on Google Code with ID 118

What steps will reproduce the problem?
1. Site users -> newteam
2. Fill in team name, add a repository
3. Click Save

What is the expected output? What do you see instead?
error message "Failed to add team!" is displayed, but was created anyways.

What version of the product are you using? On what operating system?
1.0.0, Linux Debian and Apache mod_proxy with http

Please provide any additional information below.
Setting changed: web.mountParameters=false

Reported by pummer.thomas@nullpointer.at on 2012-08-03 10:45:54

[gitblit]

Are you using GO or WAR?

Reported by James.Moger on 2012-08-03 11:53:39

[gitblit]

GO is used.

Sorry, i've forgotten to add that.

Reported by pummer.thomas@nullpointer.at on 2012-08-03 13:15:24

[gitblit]

Hmmm.  What is your realm.userService value?  If it is the default, are you running
GO as your account or as a service?  Could it be a file permissions problem?  Any stacktraces
in the console?

Reported by James.Moger on 2012-08-03 13:26:14

[gitblit]

realm.userService is default users.conf and i'm running it as a service with it's own
user. U are right, it is a file permission problem.


ERROR Failed to update team model test3!
java.io.IOException: Permission denied
        at java.io.UnixFileSystem.createFileExclusively(Native Method)
        at java.io.File.createNewFile(File.java:900)
        at org.eclipse.jgit.storage.file.LockFile.lock(LockFile.java:159)
        at org.eclipse.jgit.storage.file.FileBasedConfig.save(FileBasedConfig.java:175)
        at com.gitblit.ConfigUserService.write(ConfigUserService.java:792)
        at com.gitblit.ConfigUserService.updateTeamModel(ConfigUserService.java:506)
        at com.gitblit.GitblitUserService.updateTeamModel(GitblitUserService.java:259)
        at com.gitblit.GitBlit.updateTeamModel(GitBlit.java:710)
        at com.gitblit.wicket.pages.EditTeamPage$1.onSubmit(EditTeamPage.java:201)
        ...

Have to change the "What do you see instead?"
After getting the "Failed to add team!" Message, it is shown on the users view, but
on the next start, the new team isn't shown anymore.

Reported by pummer.thomas on 2012-08-05 21:52:48

[gitblit]

I'll see if I can improve the error message in this case.

The other bit (team is there until restart) is because Gitblit first updates it's memory
cache of teams/users and then writes to disk from the cache.  In your case the cache
updated but failed to persist.  So you see the team in the UI until restart. I'll see
if I can improve that too.

Reported by James.Moger on 2012-08-06 12:54:58

[gitblit]

The exception is buried too deeply at the moment to propagate the message out.

I have made changes to restore the previous user and/or team objects in the event of
update failure or to remove a failed user/team addition.  That should at least meet
the expectation of not displaying a new team that failed the creation step.  :)

Reported by James.Moger on 2012-08-06 21:43:31

• Status changed: Queued
• Labels added: Milestone-1.0.1

[gitblit]

Reported by James.Moger on 2012-08-20 02:06:35

• Labels added: Milestone-1.1.0
• Labels removed: Milestone-1.0.1

[gitblit]

Fix/change released in 1.1.0.

Reported by James.Moger on 2012-08-25 12:20:42

• Status changed: Fixed