Activity Charts broken

[gitblit]

Originally reported on Google Code with ID 176

Hello,

we converted various cvs projects to git repositories. Due to "issues" during the conversion
some fields contained empty strings or newline chars. This breaks the generated javascript
code in the activity page.

Example Source Code:

...
data_39b7080b.setValue(4, 1, 9.0);
data_39b7080b.setValue(5, 0, '
');
data_39b7080b.setValue(5, 1, 6.0);
...


The problematic code parts are located in GooglePieChart.java and GoogleLineChart.java
in the method "appendChart":

...
this.line(sb, MessageFormat.format("{0}.setValue({1,number,0}, 0, ''{2}'');", dName,
i, value.name));
...

"value.name" must not contain any newline chars !

I am not sure if this can also break other things, we only recognized issues on the
activity page by now.

Best Regards
Daniel

Reported by weird.address on 2012-12-07 11:24:37

[gitblit]

The issue must be newlines in the author's email address field.  This may get you into
trouble elsewhere - and not just Gitblit.

Reported by James.Moger on 2012-12-07 13:11:39

• Status changed: Accepted
• Labels added: Milestone-1.2.0

[gitblit]

Reported by James.Moger on 2012-12-07 14:27:13

• Status changed: Queued

[gitblit]

v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:26

• Status changed: Fixed