Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendmail.groovy and sendmail-html.groovy try to mail even if no recipient #497

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

sendmail.groovy and sendmail-html.groovy try to mail even if no recipient #497

gitblit opened this issue Aug 12, 2015 · 3 comments
Assignees
@gitblit
Labels
🐱 Defect Priority-Medium Status-Fixed
Milestone
1.3.0

Comments

@gitblit
Copy link
Collaborator

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 201

Currently sendmail.groovy and sendmail-html.groovy try to mail even if no mailinglist
has been set for the repo and no mail.mailinglist has been defined in gitlib.properties.

Perhaps the groovy scripts could check that 'toAddresses' is not empty before composing
the message and sending it. This would save processing time and also avoid the errors
[1] that now appear in the log for such repos.

[1] "ERROR Failed to send message
javax.mail.SendFailedException: No recipient addresses"

Reported by martijnlaan on 2013-02-08 12:19:36
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-02-08 12:48:04

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0

@gitblit gitblit self-assigned this Aug 12, 2015
@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Fixed on master.
Thanks for the report.

Reported by James.Moger on 2013-03-28 21:33:29

  • Status changed: Queued

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015 

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix modified the milestone: 1.3.0 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitblit gitblit

Labels
🐱 Defect Priority-Medium Status-Fixed
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@gitblit @flaix