NPE: when pushing changes to newly forked repo

[gitblit]

Originally reported on Google Code with ID 253

What steps will reproduce the problem?
1. fork a repo
2. clone new repo locally
3. make/commit/push new change
4. GitBlit shows a NullPointerException

For the client, I use TortoiseGit, but this also happens on the command line.
If I restart the GitBlit server, then try to push, the command completes successfully.


What is the expected output? What do you see instead?
The expected output is for the push to complete. 

The server console shows:

INFO  ralim authenticated by BASIC request header from 10.244.140.66
INFO  ARF: ~ralim/ue_tracker.git/info/refs?service=git-receive-pack (100) authen
ticated
INFO  ralim authenticated by BASIC request header from 10.244.140.66
INFO  ARF: ~ralim/ue_tracker.git/git-receive-pack (100) authenticated
WARN  Internal error during receive-pack
java.lang.NullPointerException
        at java.util.AbstractCollection.addAll(AbstractCollection.java:303)
        at com.gitblit.GitServlet$GitblitReceiveHook.onPreReceive(GitServlet.java:275)
        at org.eclipse.jgit.transport.ReceivePack.service(ReceivePack.java:203)
        at org.eclipse.jgit.transport.ReceivePack.receive(ReceivePack.java:160)
        at org.eclipse.jgit.http.server.ReceivePackServlet.doPost(ReceivePackSer
vlet.java:187)


The output on the Client side shows:

Total 2 (delta 0), reused 0 (delta 0)
send-pack: protocol error: bad band #101
fatal: The remote end hung up unexpectedly
fatal: The remote end hung up unexpectedly

What version of the product are you using? On what operating system?
v.1.2.1

Please provide any additional information below.

Reported by rayjlim1 on 2013-06-11 18:14:32

[gitblit]

Reported by James.Moger on 2013-06-11 18:53:51

• Status changed: Accepted
• Labels added: Milestone-1.3.0

[gitblit]

Trying to help. :)
I see the lines 172-173
                scripts.addAll(GitBlit.self().getPreReceiveScriptsInherited(repository));
scripts.addAll(repository.preReceiveScripts);

in ReceiveHook.java
https://code.google.com/p/gitblit/source/browse/src/main/java/com/gitblit/git/ReceiveHook.java

Reported by rayjlim1 on 2013-06-11 19:35:06

[gitblit]

Yup.  That's it.  That collection is null after a fork because it's never set by the
fork method and the model from the fork is cached.  On a reload everything is just
dandy.

Reported by James.Moger on 2013-06-11 19:43:11

[gitblit]

Reported by James.Moger on 2013-06-11 20:02:05

• Status changed: Queued

[gitblit]

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

• Status changed: Fixed