Daily log file logging

[gitblit]

Originally reported on Google Code with ID 348

I was unable to find a way to specify a location where Gitblit logs its output, so I
ended up making some changes to the Ubuntu service script (also includes the pidfile
tweak to avoid hardcoding the same path twice and an option to show the log). The patch
is enclosed.

Of course, it would be much better to handle this from within the webapp, i.e. a command
line argument, like

java -jar gitblit.jar --logFolder $GITBLIT_BASE_FOLDER/log

or something. What do you guys think?

Reported by sundayfunday1234@outlook.com on 2013-12-05 10:43:55

---

- _Attachment:

service-ubuntu.patch

[gitblit]

I forgot to mention that making this a command line argument is also crucial in regards
of file permissions. start-stop-daemon sets up permissions fine for everything in its
arguments (apparently), but this >> hack will only work correctly if you run Gitblit
as root, because start-stop-daemon is invoked as root so the redirected output will
also be owned by root, no matter what you set with --chuid.

Reported by sundayfunday1234@outlook.com on 2013-12-05 10:49:21

[gitblit]

I agree, this needs improvement.

Reported by James.Moger on 2013-12-05 13:09:02

• Status changed: Accepted
• Labels added: Milestone-1.4.0

[gitblit]

I've pushed a new command-line launch argument for GO that disables stdout logging and
enables daily, rolling log files in ${baseFolder}/logs.  It is not configurable.  It
is just a flag for controlling "log to console" or "log to daily log file".

Reported by James.Moger on 2014-02-21 16:19:15

• Status changed: Queued

[gitblit]

Issue 580 has been merged into this issue.

Reported by James.Moger on 2014-02-21 16:25:36

[gitblit]

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

• Status changed: Done

[gitblit]

James, thanks, it's very cool, but would you please consider adding this to the services
as well? E.g. in service-ubuntu.sh

- ARGS="-server -Xmx1024M ${JAVA_PROXY_CONFIG} -Djava.awt.headless=true -jar gitblit.jar
--baseFolder $GITBLIT_BASE_FOLDER"
+ ARGS="-server -Xmx1024M ${JAVA_PROXY_CONFIG} -Djava.awt.headless=true -jar gitblit.jar
--baseFolder $GITBLIT_BASE_FOLDER --dailyLogFile"

Reported by sundayfunday1234@outlook.com on 2014-03-28 18:12:56

[gitblit]

A reasonable suggestion.  Pushed to master.

Reported by James.Moger on 2014-03-29 00:21:35

[gitblit]

Thanks James!

Reported by sundayfunday1234@outlook.com on 2014-03-29 00:39:32