Special chars in repo / folder names

[gitblit]

Originally reported on Google Code with ID 362

What steps will reproduce the problem?
1. create a repo named 'hähä'
2. try to clone

What is the expected output? What do you see instead?
On git-receive-pack you will git HTTP 404


What version of the product are you using? On what operating system?
1.3.2

Please provide any additional information below.

In com.gitblit.AuthenticationFilter.getFullUrl(HttpServletRequest) we need to unescape
the URL, see pull request.

Reported by matthias.cullmann on 2014-01-28 10:15:09

[gitblit]

I created a pull request under:
https://github.com/gitblit/gitblit/pull/136

Reported by matthias.cullmann on 2014-01-28 10:18:00

[gitblit]

Thanks for the patch.  Merged.

Reported by James.Moger on 2014-01-28 12:50:33

• Status changed: Queued
• Labels added: Milestone-1.4.0

[gitblit]

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

• Status changed: Done

[gitblit]

Hi Matthias,

Your change that I merged in pr-136 is causing failures.  I retested the scenario reported
 here and I am able to clone just fine without the fix.  I am considering reverting
the change made in pr-136 since I don't see evidence that it improves things and in
fact, I have evidence that it breaks cloning.

Can you craft a new failure scenario or have a comment?

-J

Reported by James.Moger on 2014-06-10 21:23:56

• Status changed: New

[gitblit]

Well, it might depend on the encoding settings on the OS / VM.
If you feel it is not an improvement, then of course you should revert.

Reported by matthias.cullmann on 2014-06-11 16:51:34

[gitblit]

What were your client & server platforms when you came across this issue?

Reported by James.Moger on 2014-06-11 16:53:31

[gitblit]

I reverted pr-136 in 1.6.0.

Reported by James.Moger on 2014-06-17 00:25:42

• Status changed: Done