Internal error after simple commit

[gitblit]

Originally reported on Google Code with ID 401

What steps will reproduce the problem?
1. Create repo from gitblit np. free/free.git
2. On linux do these commands

git clone ...
git remote add free ....
touch test - create new file 
git add . 
git commit
git push free master

What is the expected output? What do you see instead?
On gitblit front on main page I have internal error. 

What version of the product are you using? On what operating system?
Gitblit 1.3.2 Centos 6.4

Please provide any additional information below.
In log I've got this:

2014-03-27 15:20:44 RequestCycle [ERROR] Can't instantiate page using constructor public
com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters) and argument
r = "mati/matitest.git"
 org.apache.wicket.WicketRuntimeException: Can't instantiate page using constructor
public com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters) and argument
r = "mati/matitest.git"
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:212)
    at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:89)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.newPage(BookmarkablePageRequestTarget.java:305)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.getPage(BookmarkablePageRequestTarget.java:320)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.processEvents(BookmarkablePageRequestTarget.java:234)
    at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
    at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1279)
    at org.apache.wicket.RequestCycle.step(RequestCycle.java:1358)
    at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1465)
    at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
    at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
    at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1300)
    at com.gitblit.EnforceAuthenticationFilter.doFilter(EnforceAuthenticationFilter.java:87)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1300)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:445)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:556)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:227)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1038)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:374)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:189)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:972)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
    at org.eclipse.jetty.server.Server.handle(Server.java:363)
    at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:483)
    at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:920)
    at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:982)
    at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:635)
    at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
    at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
    at org.eclipse.jetty.io.nio.SslConnection.handle(SslConnection.java:196)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:628)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
    at java.lang.Thread.run(Thread.java:744)
Caused by: java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:188)
    ... 37 more
Caused by: java.lang.NullPointerException
    at com.gitblit.models.RefModel.getDate(RefModel.java:57)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:141)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:35)
    at java.util.ComparableTimSort.countRunAndMakeAscending(ComparableTimSort.java:290)
    at java.util.ComparableTimSort.sort(ComparableTimSort.java:157)
    at java.util.ComparableTimSort.sort(ComparableTimSort.java:146)
    at java.util.Arrays.sort(Arrays.java:472)
    at java.util.Collections.sort(Collections.java:155)
    at com.gitblit.utils.JGitUtils.getRefs(JGitUtils.java:1587)
    at com.gitblit.utils.JGitUtils.getAllRefs(JGitUtils.java:1455)
    at com.gitblit.wicket.panels.LogPanel.<init>(LogPanel.java:60)
    at com.gitblit.wicket.pages.SummaryPage.<init>(SummaryPage.java:136)
    ... 42 more

Reported by elo.freelancer on 2014-03-27 14:44:38

[gitblit]

That's an odd one.  It looks like your committer id is null.

Check the log of that commit from your client.

    git log -n1 --format=full

Reported by James.Moger on 2014-03-27 14:56:59

[gitblit]

Thanks for rply. 

I'll paste all my logs:


[mati:/tmp/gittemp2]$ git clone https://free@gitblit/git/mati/test.git .
Cloning into '.'...
Password for 'https://free@gitblit': 
warning: You appear to have cloned an empty repository.
Checking connectivity... done
[mati:/tmp/gittemp2]$ ls -al                                          (master) 
razem 12
drwxr-xr-x  3 mati mati 4096 mar 27 16:22 .
drwxrwxrwt 25 root root 4096 mar 27 16:17 ..
drwxr-xr-x  7 mati mati 4096 mar 27 16:22 .git
[mati:/tmp/gittemp2]$ touch test.txt                                     (master) 
[mati:/tmp/gittemp2]$ git add test.txt                               (master✱) 
[mati:/tmp/gittemp2]$ git commit                                     (master✱) 
[master (root-commit) 4854651] testtest
 1 file changed, 1 insertion(+)
 create mode 100644 test.txt
[mati:/tmp/gittemp2]$ git remote add gitblit https://free@gitblit/git/mati/test.git
[mati:/tmp/gittemp2]$ git push gitblit master                         (master) 
Password for 'https://free@gitblit': 
Counting objects: 3, done.
Writing objects: 100% (3/3), 217 bytes | 0 bytes/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: Updating references: 100% (1/1)
To https://free@gitblit/git/mati/test.git
 * [new branch]      master -> master

[mati:/tmp/gittemp2]$ git log -n1 --format=full                       (master) 

commit 4854651a2e40ab74db8d6617527c27739e51f91b
Author: free <elo.freexxx@gmail.com>
Commit: free <elo.freexxx@gmail.com>

    testtest

Reported by elo.freelancer on 2014-03-27 15:30:11

[gitblit]

After that when I tried to restart gitblit server in log got:

 2014-03-27 15:02:39 GitBlit [ERROR] Failed to configure JGit parameters!
 java.lang.IllegalArgumentException: Window size must be power of 2
        at org.eclipse.jgit.internal.storage.file.WindowCache.bits(WindowCache.java:129)
        at org.eclipse.jgit.internal.storage.file.WindowCache.<init>(WindowCache.java:258)
        at org.eclipse.jgit.internal.storage.file.WindowCache.reconfigure(WindowCache.java:159)
        at org.eclipse.jgit.storage.file.WindowCacheConfig.install(WindowCacheConfig.java:225)
        at com.gitblit.GitBlit.configureJGit(GitBlit.java:3539)
        at com.gitblit.GitBlit.configureContext(GitBlit.java:3479)
        at com.gitblit.GitBlitServer.start(GitBlitServer.java:385)
        at com.gitblit.GitBlitServer.main(GitBlitServer.java:122)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.moxie.MxLauncher.main(MxLauncher.java:129)


And fronted doesn't start until I delete the files physically. 

Reported by elo.freelancer on 2014-03-27 15:36:15

[gitblit]

The window size is a different problem.  Sounds like you have adjusted the JGit config
settings.  Perhaps set them back to the defaults and see how that works out.

Reported by James.Moger on 2014-03-27 16:02:34

[gitblit]

Ok but I dont use jgit only git package.

Reported by elo.freelancer on 2014-03-27 16:23:39

[gitblit]

Gitblit uses JGit and that is where the window size error is coming from.

gitblit.properties: git.* options.

That exception is from this setting:

git.packedGitWindowSize = 8k

default is 8k

Reported by James.Moger on 2014-03-27 16:27:22

[gitblit]

Any news?

Reported by James.Moger on 2014-03-29 00:11:02

[gitblit]

Hi,

I installed the new version of gitblit GO 1.4.1 with java 6u45. And have the same problem:

[mati:~/Tmp/gittemp]$ ls -la
razem 12
drwxr-xr-x  3 mati mati 4096 kwi  7 14:47 .
drwxrwxr-x 29 mati mati 4096 mar 28 11:48 ..
drwxr-xr-x  2 mati mati 4096 kwi  7 13:35 test
[mati:~/Tmp/gittemp]$ git init .  
Initialized empty Git repository in /home/mati/Tmp/gittemp/.git/
[mati:~/Tmp/gittemp]$ git add .                                      (master✱) 
[mati:~/Tmp/gittemp]$ git commit -a -m 'test'                        (master✱) 
[master (root-commit) 1a15c00] test
 1 file changed, 1 insertion(+)
 create mode 100644 test/test.txt 
[mati:~/Tmp/gittemp]$ git remote add origin http://mati@gitblit/r/mati/test.git
[mati:~/Tmp/gittemp]$ git push -u origin --all                        (master) 
Password for 'http://mati@gitblit': 
Counting objects: 4, done.
Writing objects: 100% (4/4), 253 bytes | 0 bytes/s, done.
Total 4 (delta 0), reused 0 (delta 0)
remote: Updating references: 100% (1/1)
To http://mati@gitblit/r/mati/test.git
 * [new branch]      master -> master
Branch master set up to track remote branch master from origin.

In logs have the same:

2014-04-07 14:50:22 RequestCycle [ERROR] Can't instantiate page using constructor public
com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters) and argument
r = "mati/test.git"
 org.apache.wicket.WicketRuntimeException: Can't instantiate page using constructor
public com.gitblit.wicket.pages.SummaryPage(org.apache.wicket.PageParameters) and argument
r = "mati/test.git"
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:212)
    at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:89)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.newPage(BookmarkablePageRequestTarget.java:305)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.getPage(BookmarkablePageRequestTarget.java:320)
    at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.processEvents(BookmarkablePageRequestTarget.java:234)
    at org.apache.wicket.request.AbstractRequestCycleProcessor.processEvents(AbstractRequestCycleProcessor.java:92)
    at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:1279)
    at org.apache.wicket.RequestCycle.step(RequestCycle.java:1358)
    at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1465)
    at org.apache.wicket.RequestCycle.request(RequestCycle.java:545)
    at org.apache.wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:486)
    at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:319)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1482)
    at com.gitblit.servlet.EnforceAuthenticationFilter.doFilter(EnforceAuthenticationFilter.java:86)
    at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474)
    at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
    at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
    at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
    at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
    at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428)
    at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
    at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
    at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
    at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
    at org.eclipse.jetty.server.Server.handle(Server.java:370)
    at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
    at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:949)
    at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1011)
    at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)
    at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
    at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:668)
    at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:52)
    at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
    at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
    at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
    at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
    at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:188)
    ... 36 more
Caused by: java.lang.NullPointerException
    at com.gitblit.models.RefModel.getDate(RefModel.java:57)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:141)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:35)
    at java.util.Arrays.mergeSort(Arrays.java:1144)
    at java.util.Arrays.sort(Arrays.java:1079)
    at java.util.Collections.sort(Collections.java:115)
    at com.gitblit.utils.JGitUtils.getRefs(JGitUtils.java:1771)
    at com.gitblit.utils.JGitUtils.getRefs(JGitUtils.java:1732)
    at com.gitblit.utils.RefLogUtils.getRefLogBranch(RefLogUtils.java:125)
    at com.gitblit.wicket.pages.RepositoryPage.registerPages(RepositoryPage.java:196)
    at com.gitblit.wicket.pages.RepositoryPage.<init>(RepositoryPage.java:153)
    at com.gitblit.wicket.pages.SummaryPage.<init>(SummaryPage.java:67)
    ... 41 more

Reported by elo.freelancer on 2014-04-07 13:02:24

[gitblit]

After upgrade of course problem with jgit parameteres disappeared but still after commit
and push problem with interal error exists. 

When I try to restart application I've got:

 2014-04-07 15:37:03 WebAppContext [WARN] Failed startup of context o.e.j.w.WebAppContext{/,file:/var/www/gitblit-141/data/temp/webapp/},file:/var/www/gitblit-141/gitblit.jar
 java.lang.NullPointerException
    at com.gitblit.models.RefModel.getDate(RefModel.java:57)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:141)
    at com.gitblit.models.RefModel.compareTo(RefModel.java:35)
    at java.util.Arrays.mergeSort(Arrays.java:1144)
    at java.util.Arrays.sort(Arrays.java:1079)
    at java.util.Collections.sort(Collections.java:115)
    at com.gitblit.utils.JGitUtils.getRefs(JGitUtils.java:1771)
    at com.gitblit.utils.JGitUtils.getAllRefs(JGitUtils.java:1639)
    at com.gitblit.utils.CommitCache.get(CommitCache.java:224)
    at com.gitblit.utils.CommitCache.getCommits(CommitCache.java:174)
    at com.gitblit.utils.CommitCache.getCommits(CommitCache.java:138)
    at com.gitblit.manager.RepositoryManager.configureCommitCache(RepositoryManager.java:1806)
    at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:158)
    at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:99)
    at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:206)
    at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:181)
    at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:130)
    at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:782)
    at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:424)
    at org.eclipse.jetty.server.handler.ContextHandler.startContext(ContextHandler.java:774)
    at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:249)
    at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1242)
    at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:717)
    at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:494)
    at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:64)
    at org.eclipse.jetty.server.handler.HandlerWrapper.doStart(HandlerWrapper.java:95)
    at org.eclipse.jetty.server.Server.doStart(Server.java:282)
    at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:64)
    at com.gitblit.GitBlitServer.start(GitBlitServer.java:456)
    at com.gitblit.GitBlitServer.main(GitBlitServer.java:129)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:597)
    at org.moxie.MxLauncher.main(MxLauncher.java:129)

Reported by elo.freelancer on 2014-04-07 13:44:20

[gitblit]

Both stacktraces are caused by the same problem: a null value in determining the date
of the commit from the committer identity.  Earlier in git history, there were some
oddities in parsing commits written by buggy git versions but I haven't seen those
in a couple years.  I am trapping and working around your particular case, but I find
it unsettling.  What version of git are you using?  Can you attach your test repo for
me to poke at?

Reported by James.Moger on 2014-04-08 04:13:37

• Status changed: Queued
• Labels added: Milestone-1.5.0