Symbolically linked directories prevent app from starting within Tomcat

[gitblit]

Originally reported on Google Code with ID 511

What steps will reproduce the problem?
1: using a symbolic link in the git.repositoriesFolder prevents Tomcat from starting
the application.  I can remove the symbolic link, start Tomcat and successfully start
gitblit, and then relink the directory and the application will run fine (until Tomcat
needs to restart).

What is the expected output?
For the application to successfully start in Tomcat.

What do you see instead?
2014-10-07 15:20:10 [INFO ] ----[com.gitblit.manager.IRepositoryManager]----
2014-10-07 15:20:10 [INFO ] Repositories folder : /apps/gitrepos
2014-10-07 15:20:10 [INFO ] Identifying repositories...
Oct 07, 2014 3:20:13 PM org.apache.catalina.core.StandardContext listenerStart
SEVERE: Exception sending context initialized event to listener instance of class com.gitblit.servlet.GitblitContext
java.lang.NullPointerException
        at com.gitblit.manager.RepositoryManager.getRepositoryModel(RepositoryManager.java:705)
        at com.gitblit.manager.RepositoryManager.getRepositoryList(RepositoryManager.java:551)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:156)
        at com.gitblit.manager.RepositoryManager.start(RepositoryManager.java:100)
        at com.gitblit.servlet.GitblitContext.startManager(GitblitContext.java:229)
        at com.gitblit.servlet.GitblitContext.configureContext(GitblitContext.java:186)
        at com.gitblit.servlet.GitblitContext.contextInitialized(GitblitContext.java:131)
        at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4973)
        at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5467)
        at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
        at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)
        at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)
        at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:632)
        at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:670)
        at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1839)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
        at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
        at java.util.concurrent.FutureTask.run(FutureTask.java:166)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:724)



What version of the product are you using? On what operating system?
gitblit 1.6.0
RHEL 5.5
Tomcat 7.0.52
Java: Oracle JDK 1.7.0_25

Please provide any additional information below.

Related to issue #217

Reported by jliedy on 2014-10-07 20:47:34

[gitblit]

I've found a bug in determining the relative path for a repo from the basefolder when
using a symbolic link, which I have fixed.  But I think your problem was addressed
before this by some fixes to repository cache handling.  Either way, if you build from
master I think it'll work better for you.

Reported by James.Moger on 2014-10-10 16:12:30

• Status changed: Queued
• Labels added: Milestone-1.6.1

[gitblit]

v1.6.1 released

Reported by James.Moger on 2014-10-20 21:36:03

• Status changed: Done