Skip to content

Fixes #964 - add missing redirect after restoring user in new session - #1087

Merged
paulsputer merged 1 commit into
gitblit-org:masterfrom
mereth:issues/964-session-loss-redirects-to-start-page
Jun 19, 2016
Merged

Fixes #964 - add missing redirect after restoring user in new session#1087
paulsputer merged 1 commit into
gitblit-org:masterfrom
mereth:issues/964-session-loss-redirects-to-start-page

Conversation

@mereth

@mereth mereth commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

Hi,

I may have a fix for #964.

If web.authenticateViewPages is set to true, and when the session is invalidated due to server restart or if the max inactive interval has been reached (default 30mn) :

  • AuthorizationStrategy.isPageAuthorized save the target url and return false for any page except the homepage
  • AuthorizationStrategy.onUnauthorizedInstantiation redirect internally to the homepage
  • SessionPage.login restore user informations and the homepage is rendered

It seems it was missing the redirect to the saved target url to render the correct page

Regards

@paulsputer

Copy link
Copy Markdown
Collaborator

Thanks @mereth that's a great one-liner and does appear to have fixed #964

@paulsputer
paulsputer merged commit 3168c7f into gitblit-org:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants