Update new jgit release (4.8.0.201706111038-r) - #1252
Closed
jvanhercke wants to merge 1 commit into
Closed
Conversation
Current release of gitblit is based on version 4.1.1.201511131810-r which fails to start throwing an UnsupportedCharsetException if a commit contains an unknown character set encoding (e.g. System). This new jgit version recovers from the exception. See changes to class org.eclipse.jgit.util.RawParseUtils, public static Charset parseEncoding(final byte[] b)
Collaborator
|
The more recent releases of JGit are also the cause of performance regressions in Gerrit due to autogc. I haven't really investigated it myself, that is the scuttlebutt on the JGit mailing list. As for the charset issue, I did run into that a long while ago. My solution at the time was to hack the fix into JGit using reflection. Perhaps you could determine the offending charset and map it here. |
Author
|
Ok, I understand. I will look into it. Nice hack b.t.w., but unfortunately it does not prevent the system from crashing. |
davido
added a commit
to davido/gitblit
that referenced
this pull request
Jul 8, 2018
flaix
added a commit
to flaix/gitblit
that referenced
this pull request
Nov 11, 2022
This branch mostly records the commit from PR gitblit-org#1253, so we have it in the code base. The changes are immediately undone, because the update to JGit version 4.8.0, as proposed in PR gitblit-org#1252, renders the whole patching of JGit obsolete. The update is done now, against reservations in that PR, because we guess that potential issues have been found and fixed by now. JGit is updated to the last version on the major version 4 line: 4.11.9. Also, since upstream JGit is at v6 by now, more updates will have to happen later on anyways. To make the protection against illegal character sets complete, an additional fix for Bugtraq is included, that protects against exceptions from bugtraq should it encounter an `encoding` that cannot be handled.
Member
|
This has been implemented in commit e8a7b2d. I even advanced the JGit version up to the latest 4.x version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current release of gitblit is based on version 4.1.1.201511131810-r
which fails to start throwing an UnsupportedCharsetException if a
commit contains an unknown character set encoding (e.g. System).
This new jgit version recovers from the exception.
See changes to class org.eclipse.jgit.util.RawParseUtils,
public static Charset parseEncoding(final byte[] b)