Dutch translation - #150
Conversation
Conflicts: src/main/java/com/gitblit/wicket/GitBlitWebApp_nl.properties
|
I manually merged your changes due to the complexity of the commit history in this pull request. In general it's a good idea to create a topic branch (i.e. do not use your master). This allows you to fast-forward fetch my master onto your master and for me to cleanly grab your topic branch. The commit history here is complex because of merging with my master instead of basing your changes on my master. Thanks for the translation updates! I've updated my dev server and assuming your browser is setup for nl it should be in Dutch: https://dev.gitblit.com |
|
Hi James, Strangely enough I am a big fan of git (and Gitblit!) I know you have better things to do, but if you could Kind regards and again, thanks for such a wonderfull piece of software! Jeroen op 06-03-14 20:17, James Moger schreef:
Jeroen Baten | EMAIL : JBATEN@I2RS.NL |
|
Here is the general idea to get back to a happy place right now.
Once you are at that step do this: That will add my github repo as one of your remotes. When you want to start on a new pull request follow this plan That pull syntax help to ensure your have not commited to master in your repo - which in a fork is a bad idea. Think of master in your fork as mine - even though it is technically yours. :) This will push your branch up to GitHub - then create your PR as usual. That is the general idea. Where things go wrong is when we are both working on the same branch and we merge things back & forth at different times. We might end up in the same place, but the pathways are different and if you create a PR from your master to mine with all those pathways, then you are asking me to pull all your merge commits into my repo too. Summary: short-lived topic branches are good, continue to pull my master to keep up-to-date. Git, of, course, is quite good at recursive merges so you probably could keep working & creating PRs from a master branch, but it makes people frown because it creates alot of commit noise in the repository. Thanks again for the speedy translation! |
|
Github destroyed the formatting since I sent form email. I've edited my comment for readability. |
|
This is such a nice overview! Big thanks! Jeroen op 06-03-14 22:13, James Moger schreef:
Jeroen Baten | EMAIL : JBATEN@I2RS.NL |
|
Except for the change in the original file, this workflow has helped me op 06-03-14 22:13, James Moger schreef:
Jeroen Baten | EMAIL : JBATEN@I2RS.NL |
Here you go. Succes!