Add option to explicitly specify the use of STARTTLS #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for servers that use STARTTLS without SMTPS such as Office 365
gitblit
added a commit
that referenced
this pull request
May 8, 2014
Add option to explicitly specify the use of STARTTLS
gitblit
added a commit
that referenced
this pull request
Sep 17, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for servers that use STARTTLS without SMTPS such as Office 365
Please note that I didn't touch the if (isGMail || smtps) part where you also enable STARTTLS. I'm unsure if STARTTLS is mandatory for those, so I guess the safer choice is not to change them.