Support for different post/host in the ssh://... url in the web interface. - #268
Support for different post/host in the ssh://... url in the web interface.#268bogeskov wants to merge 2 commits into
Conversation
Running gitblit in a container it's easy to expose the ssh on the default port. Using git.sshDisplayPort/git.sshDisplayHost you can expose the forwarded address as the official location.
|
I understand the use-case for the port. I am not understanding the hostname setting. When would the hostname in |
|
The reason for the git.sshDisplayHost, is that the primary url is mapped into an apache with proxypass together with some other services (/artifactory, /jenkins, /moinmoin , /sonarqube, ...), so that I have only one http entrypoint. But the ssh is on the server that actually runs the docker gitblit container. |
Running gitblit in a container it's easy to expose the ssh on the default port. Using git.sshDisplayPort/git.sshDisplayHost you can expose the forwarded address as the official location. Handle undefined (empty defined) settings.
|
Just realized that I didn't handle empty settings properly. Committed a fix to that. |
|
I manually merged & revised your contribution to the |
I've tried to run gitblit in a docker container, and wanted to run the ssh server on what looks like port 22.
However I didn't want to run it as root. So I exposed the default port as (server's 2nd ip) port 22.
Then I would like an easy way of using this port in the web interface.
So I added git.sshDisplayHost/Port to the config.
Commit comment:
Added git.sshDisplay{Port|Host} to hide port forward.
Running gitblit in a container it's easy to expose the ssh on the default port.
Using git.sshDisplayPort/git.sshDisplayHost you can expose the forwarded address
as the official location.