Add "all repositories" parameter - #935
Merged
Merged
Conversation
Collaborator
There was a problem hiding this comment.
Let's tweak this to "All Repositories" so that it can be used elsewhere in the app, if needed.
Collaborator
|
@vitalif This looks great. Make the small tweak and I'll merge. |
Author
|
There's an additional defect which should also be fixed: current implementation can duplicate the same repository multiple times in searchRepositories. In fact, you can even pass the same repository multiple times in the query parameter: /lucene/?query=xxx&repositories=repo+repo+repo, and it will lead to duplicate search results :) |
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in Gitblit you must explicitly list all repositories to search in them. This does not allow to conveniently link to search page, for example, from a bugtracker. This patch adds "in all repositories" parameter so you can link to /lucene/?allrepos=1&query=$q or select a checkbox in the UI :)