Refactor authentication for servlet HTTP header handler - #980
Merged
Conversation
mrjoel
force-pushed
the
mrjoel-httpheaders
branch
2 times, most recently
from
December 9, 2015 06:22
a395b2d to
aed0aa3
Compare
This was unused and causing provider lookup to fail in AuthenticationManager.findProvider() by changing it out from underneath. As a result, the supportXChanges methods weren't being reported correctly.
mrjoel
force-pushed
the
mrjoel-httpheaders
branch
from
December 9, 2015 14:41
aed0aa3 to
fd0fc5f
Compare
Collaborator
|
✨ Nice & clean. Great job. |
gitblit
added a commit
that referenced
this pull request
Dec 10, 2015
Refactor authentication for servlet HTTP header handler
Collaborator
|
I granted you contributor access for easier branch-based PRs rather than from forks. Thanks for all your contributions. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update of #273, nearly identical except updated to work with #908 as indicated in the original.