Skip to content

fix for #978 - HTML5 date input support - #982

Merged
gitblit merged 1 commit into
masterfrom
978-milestone-date-selector
Dec 10, 2015
Merged

fix for #978 - HTML5 date input support#982
gitblit merged 1 commit into
masterfrom
978-milestone-date-selector

Conversation

@paulsputer

Copy link
Copy Markdown
Collaborator
  • JS patch/hack to coerce legacy wicket into talking to a HTML5 input type
  • JS script to hide inline help on date format when using HTML5 date picker
    • Date picker shown in user locale and standard does not support custom
      format.
    • Always sent in ISO8601 format

+ JS patch/hack to coerce legacy wicket into talking to a HTML5 input type
+ JS script to hide inline help on date format when using HTML5 date picker
  + Date picker shown in user locale and standard does not support custom
  format.
  + Always sent in ISO8601 format
@gitblit

gitblit commented Dec 10, 2015

Copy link
Copy Markdown
Collaborator

👍 Gorgeous. Now if only all the browsers had the Chrome date picker.

gitblit added a commit that referenced this pull request Dec 10, 2015
@gitblit
gitblit merged commit 63e4d96 into master Dec 10, 2015
@bviktor

bviktor commented Dec 10, 2015

Copy link
Copy Markdown
Contributor

Does that work in Blink-based browsers, e.g. Opera?

@gitblit

gitblit commented Dec 10, 2015

Copy link
Copy Markdown
Collaborator

Blink-based, should. That's Chrome's engine now, right? Presto-based, no idea; I no longer test Opera.

@paulsputer

Copy link
Copy Markdown
Collaborator Author

@bviktor according to http://caniuse.com/#search=date Opera is supported, though I've not confirmed this. I tested:

Chrome - Supported
Edge - Supported
Firefox - Fall back to textbox (see https://bugzilla.mozilla.org/show_bug.cgi?id=825294)
IE - Fall back to textbox

@paulsputer
paulsputer deleted the 978-milestone-date-selector branch December 10, 2015 16:43
@bviktor

bviktor commented Dec 10, 2015

Copy link
Copy Markdown
Contributor

Opera is Blink-based :) Thanks for the report, @paulsputer , and also for all these nice additions recently :)

@flaix flaix modified the milestone: 1.8.0 Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants