Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
We are using reverse proxy. Gitblit is running only HTTP on port 29080 and apache does reverse proxy to HTTPS 4000.
It is caused by regression in pull request #1086, the solution of #1083.
It is because the port number is doubled. In the path, there is hardcoded check for 80 and 443, but there is no check if host already contains the port number.
With web.canonicalUrl = https://ourhost:4000 graph image is generated as
web.canonicalUrl = https://ourhost:4000
web.canonicalUrl should contain nonstandard port.
Setting just web.canonicalUrl = https://ourhost also does not work.
web.canonicalUrl = https://ourhost
The text was updated successfully, but these errors were encountered:
Yes, you're right - I didn't test with non-standart "outside" ports.
What solution do you propose? Extend the mentioned "if" to also check if "host" contains ":"?
Would you like to provide a fix / pull request?
Sorry, something went wrong.
Merge pull request #1201 from j123b567/bug/1114
Fix #1114 HttpUtils getGitblitURL does not support nonstandard ports
No branches or pull requests