New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servlet API 3 (Tomcat 7.0) Support #319

Closed
gitblit opened this Issue Aug 12, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 23

What steps will reproduce the problem?
1. Deploy gitblit 0.6.0 war on Tomcat 7 application server and configure it
2. Navigate to http://yourserver/gitblit/feed/projectname or http://yourserver/gitblit/git/projectname

What is the expected output? What do you see instead?
You'll get a HTTP 500 error page. What a see in logs:

Oct 6, 2011 5:07:09 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [SyndicationServlet] in context with path [/gitblit]
threw exception [Filter execution threw an exception] with root cause
java.lang.AbstractMethodError
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at com.gitblit.AccessRestrictionFilter.doFilter(AccessRestrictionFilter.java:216)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:224)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:185)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:151)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:269)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:300)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:680)


What version of the product are you using? On what operating system?
gitblit 0.6.0, Mac OS X Lion, Apache Tomcat/7.0.21

Please provide any additional information below.
I tried to deploy on Tomcat 6, it worked fine.

Reported by dadalar on 2011-10-07 08:41:54

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I have prototype code that works on Servlet API 3 (Tomcat 7, Jetty 8, etc)  but supporting
Servlet API 3 also means updating my Jetty dependency from 7 to 8.  I know that the
latest Jetty 7 release has a design change which creates problems for GO and I assume
that same change is in 8.

This will be on my TODO list, although I'm not sure if I will be comfortable with having
it ready for the next release (shooting for end of month).  Either way I will update
the documentation to indicate the required Servlet API version (currently 2.5).

Reported by James.Moger on 2011-10-07 12:52:38

  • Status changed: Accepted
Owner

gitblit commented Aug 12, 2015

I have prototype code that works on Servlet API 3 (Tomcat 7, Jetty 8, etc)  but supporting
Servlet API 3 also means updating my Jetty dependency from 7 to 8.  I know that the
latest Jetty 7 release has a design change which creates problems for GO and I assume
that same change is in 8.

This will be on my TODO list, although I'm not sure if I will be comfortable with having
it ready for the next release (shooting for end of month).  Either way I will update
the documentation to indicate the required Servlet API version (currently 2.5).

Reported by James.Moger on 2011-10-07 12:52:38

  • Status changed: Accepted
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I am now building against servlet api 3.0 but still running against Jetty 7 (servlet
api 2.5) and this seems to be working.  Unless I run into complications I would expect
the next release to be ready for Tomcat 7.

Reported by James.Moger on 2011-10-09 13:56:13

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect
Owner

gitblit commented Aug 12, 2015

I am now building against servlet api 3.0 but still running against Jetty 7 (servlet
api 2.5) and this seems to be working.  Unless I run into complications I would expect
the next release to be ready for Tomcat 7.

Reported by James.Moger on 2011-10-09 13:56:13

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2011-10-12 11:55:11

  • Labels added: Milestone-0.7.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2011-10-12 11:55:11

  • Labels added: Milestone-0.7.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2011-10-17 21:22:16

Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2011-10-17 21:22:16

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fix deployed in v0.7.0.

Reported by James.Moger on 2011-11-11 23:15:47

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

Fix deployed in v0.7.0.

Reported by James.Moger on 2011-11-11 23:15:47

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 0.7.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment