New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git notes not shown on commit page #366

Closed
gitblit opened this Issue Aug 12, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 70

What steps will reproduce the problem?
- Git notes are not shown on the "commit" page of Gitblit, only the commit message.
- The output of "git log" on the console looks like this:

<---start--->
commit f64c323cee2c08a64f618f46b03e90decc2a472c
Author: Joachim Schaaf <jschaaf@xxx.com>
Date:   Tue Feb 21 13:07:06 2012 +0100

    fixed

Notes (remote-notes/origin/commits):
    Push received on 'Wed, 22 Feb 2012 16:59:31 +0100' for f64c323cee2c08a64f618f46b03e
<---end--->


What is the expected output? What do you see instead?

- The Git notes should be shown on the commit page.

What version of the product are you using? On what operating system?

- Using Gitblit 0.8.2, Git 1.7.0.4 on Ubuntu 10.04 LTS (Kernel 2.6.32)

Please provide any additional information below.

- I have attached a small repository, that contains some commits with notes.

Reported by Joachim.Schaaf on 2012-03-05 07:53:52


- _Attachment: [playground.git.tgz](https://storage.googleapis.com/google-code-attachments/gitblit/issue-70/comment-0/playground.git.tgz)_
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Ok, I see the problem.  Gitblit is hard-coded to work with the standard refs/notes/
namespace.  I know that command-line Git allows you to control that.  I'll see if there
is a way Gitblit can detect this situation and Do the Right Thing.

Reported by James.Moger on 2012-03-05 12:58:39

  • Status changed: Accepted
  • Labels added: Milestone-0.9.0
Owner

gitblit commented Aug 12, 2015

Ok, I see the problem.  Gitblit is hard-coded to work with the standard refs/notes/
namespace.  I know that command-line Git allows you to control that.  I'll see if there
is a way Gitblit can detect this situation and Do the Right Thing.

Reported by James.Moger on 2012-03-05 12:58:39

  • Status changed: Accepted
  • Labels added: Milestone-0.9.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Nevermind.  That is not the problem.  The real problem is how the notes are stored in
the refs/notes/commits tree.  Gitblit assumes that notes are stored using the following
pattern:

commit 89446518fe5afeae14ca02f2ef11bfd25100e14a
note 89/446518fe5afeae14ca02f2ef11bfd25100e14a

So the note is located in the root folder 89 and the file 44651...

In your repository notes are stored in a flat hierarchy in the refs/notes/commits tree.
note 89446518fe5afeae14ca02f2ef11bfd25100e14a

I'll make Gitblit check for this scenario.  I'll have to review the Git documentation
to see if I misunderstood how Git can store notes or if there was a change somewhere
along the way.  In the JGit repository notes are stored using the nn/nnnnnnnnnnnnnnnn
pattern, which I suspect is more scalable.

Thanks for the report.

Reported by James.Moger on 2012-03-05 13:19:26


- _Attachment: playground-notes.png
![playground-notes.png](https://storage.googleapis.com/google-code-attachments/gitblit/issue-70/comment-2/playground-notes.png)_
Owner

gitblit commented Aug 12, 2015

Nevermind.  That is not the problem.  The real problem is how the notes are stored in
the refs/notes/commits tree.  Gitblit assumes that notes are stored using the following
pattern:

commit 89446518fe5afeae14ca02f2ef11bfd25100e14a
note 89/446518fe5afeae14ca02f2ef11bfd25100e14a

So the note is located in the root folder 89 and the file 44651...

In your repository notes are stored in a flat hierarchy in the refs/notes/commits tree.
note 89446518fe5afeae14ca02f2ef11bfd25100e14a

I'll make Gitblit check for this scenario.  I'll have to review the Git documentation
to see if I misunderstood how Git can store notes or if there was a change somewhere
along the way.  In the JGit repository notes are stored using the nn/nnnnnnnnnnnnnnnn
pattern, which I suspect is more scalable.

Thanks for the report.

Reported by James.Moger on 2012-03-05 13:19:26


- _Attachment: playground-notes.png
![playground-notes.png](https://storage.googleapis.com/google-code-attachments/gitblit/issue-70/comment-2/playground-notes.png)_
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2012-03-06 02:48:53

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-03-06 02:48:53

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fixed in v0.9.1

Reported by James.Moger on 2012-03-28 00:02:10

Owner

gitblit commented Aug 12, 2015

Fixed in v0.9.1

Reported by James.Moger on 2012-03-28 00:02:10

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fixed in v0.9.1. Closing.

Reported by James.Moger on 2012-03-28 00:03:13

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

Fixed in v0.9.1. Closing.

Reported by James.Moger on 2012-03-28 00:03:13

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 0.9.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment