Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase Repos not appearing on selected #367

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

Uppercase Repos not appearing on selected #367

gitblit opened this issue Aug 12, 2015 · 4 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 71

1) Create a UPPERCASE repository.
2) Go in a team configuration and add the repository to the team.
3) Save.
4) You will see that the team have 1 repository. 
5) Go back in the team configuration.
6) The repo is not in the selected.

I already had this problem on another project using wicket.
Wicket uses equals for the palette to see if an item is on left or right.

You need to override the compare to use equalsIgnoreCase if its a string. This should
go in wicket using an instanceof or something imo but you can fix it that way.



Reported by rouche on 2012-03-05 13:10:53

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Tricky.  Yup I can reproduce that, thanks for the report.

It looks like this can be handled a little more elegantly by controlling the idExpression
of the ChoiceRenderer.

http://wicket.apache.org/apidocs/1.4/org/apache/wicket/markup/html/form/ChoiceRenderer.html

I suppose the Wicket devs are optimizing for complex domain objects instead of simple
types.  My fix will be to subclass ChoiceRenderer and control the return value for
getIdValue() which is used by the palette to determine the select's options.  A quick
test shows that it works properly for your issue.

Reported by James.Moger on 2012-03-05 14:41:03

  • Status changed: Started
  • Labels added: Milestone-0.9.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-03-06 02:48:53

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fixed in v0.9.1

Reported by James.Moger on 2012-03-28 00:02:10

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fixed in v0.9.1. Closing.

Reported by James.Moger on 2012-03-28 00:03:13

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 0.9.0 milestone Dec 13, 2016
@flaix flaix added this to the 0.9.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants