Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md not well formated on gitblit #370

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

README.md not well formated on gitblit #370

gitblit opened this issue Aug 12, 2015 · 4 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 74

What steps will reproduce the problem?
1. Adding specialchars (á,é,í,ñ,etc) to the README.md
2. Adding a simple string like original_config.php to the README
3. Showing the README on Gitblit

What is the expected output? What do you see instead?
The latin or special chars readable and the string "original_config.php" not formated.
Instead a utf8 error code like a�o is showed on the specialchars and in the case of
the original_config.php It's formated in someting like original<em>config<em>.php

What version of the product are you using? On what operating system?
v.0.8.2 on CentOS

Reported by doropeza on 2012-03-16 15:58:20

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I will look into the encoding issue.

The underscore problem needs to be reported upstream @ MarkdownPapers.  I'll write
a unit test for that and submit it - not sure if it will be fixed in time for the next
release.  Maybe.

Reported by James.Moger on 2012-03-16 16:57:08

  • Status changed: Accepted
  • Labels added: Milestone-0.9.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hmmmm.  I've copied, pasted, and committed your 3 steps into a readme file.

When I test this on Debian both v0.8.2 and v0.9.0-SNAPSHOT properly interpret the accented
characters as UTF-8 and properly interpret the single underscore.  I expected this
to work because I knew the file was UTF-8 encoded and Gitblit expects all repository
content to also be UTF-8 encoded.

When I do this on Windows both v0.8.2 and v0.9.0-SNAPSHOT will fail if the file is
not UTF-8 encoded.  On my Windows box the files are CP1252-encoded unless I manually
override that.  If I leave them as CP1252 then Gitblit displays garbage characters.
 If the file is UTF-8 encoded Gitblit behaves properly.

I hate to say Works For Me so can you create and attach a small test repository that
behaves improperly on your CentOS box?

Reported by James.Moger on 2012-03-16 21:49:55

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Hi, Well in fact the development is made on windows workstations, the gitblit and repository
server are on a CentOS box. You probably found the problem with that test and obviously
almost every developer team is careless about how is encoded the markdown file :S

Reported by doropeza on 2012-03-19 13:07:02

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

That is good news.  I'm closing this issue.  Keep watching for v0.9.0 which should be
released within the next 2 weeks.

Reported by James.Moger on 2012-03-19 13:26:50

  • Status changed: WontFix

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 0.9.0 milestone Dec 13, 2016
@flaix flaix added this to the 0.9.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants