New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager can not manipulate a GO setting if the setting is unspecified in config file #381

Closed
gitblit opened this Issue Aug 12, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 85

Manager can not manipulate a GO setting if the setting is unspecified in config file

Reported by James.Moger on 2012-04-12 13:18:00

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2012-06-15 12:26:42

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-06-15 12:26:42

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Resolved in v1.0.0.

Reported by James.Moger on 2012-07-14 04:44:17

  • Status changed: Done
Owner

gitblit commented Aug 12, 2015

Resolved in v1.0.0.

Reported by James.Moger on 2012-07-14 04:44:17

  • Status changed: Done
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I thought this was fixed but it turns out my weak description of the problem was insufficient
to remind me what I needed to do.  This is still an issue in 1.0.0.

Problem only affects GO.  If we want to manipulate a setting that exists in the reference.properties
but does not exist in gitblit.properties we can not do that because gitblit.properties
is manipulated using a regex, not properties.load.  I do that so that setting documentation
is not stripped from the file, which it would be if I used the properties class to
manipulate the settings.

Need to handle case where content does not change after regex substitution.

Reported by James.Moger on 2012-08-03 14:54:40

  • Status changed: Started
  • Labels added: Milestone-1.0.1
  • Labels removed: Milestone-1.0.0
Owner

gitblit commented Aug 12, 2015

I thought this was fixed but it turns out my weak description of the problem was insufficient
to remind me what I needed to do.  This is still an issue in 1.0.0.

Problem only affects GO.  If we want to manipulate a setting that exists in the reference.properties
but does not exist in gitblit.properties we can not do that because gitblit.properties
is manipulated using a regex, not properties.load.  I do that so that setting documentation
is not stripped from the file, which it would be if I used the properties class to
manipulate the settings.

Need to handle case where content does not change after regex substitution.

Reported by James.Moger on 2012-08-03 14:54:40

  • Status changed: Started
  • Labels added: Milestone-1.0.1
  • Labels removed: Milestone-1.0.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2012-08-06 21:43:50

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-08-06 21:43:50

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2012-08-20 02:06:35

  • Labels added: Milestone-1.1.0
  • Labels removed: Milestone-1.0.1
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-08-20 02:06:35

  • Labels added: Milestone-1.1.0
  • Labels removed: Milestone-1.0.1
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fix/change released in 1.1.0.

Reported by James.Moger on 2012-08-25 12:20:42

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

Fix/change released in 1.1.0.

Reported by James.Moger on 2012-08-25 12:20:42

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 1.1.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment