Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot login when e-mail is null in LDAP directory #406

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

User cannot login when e-mail is null in LDAP directory #406

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 110

What steps will reproduce the problem?
1. Configure Gitblit to use LDAP authentication
2. Add a user in LDAP without an email
3. Try to login Gitblit
4. See the Nullpointer exception in System.err

What is the expected output? What do you see instead?
It was expected to login, but when the user e-mail is null in LDAP, we can't login

What version of the product are you using? On what operating system?
1.0.0 - Ubuntu

Please provide any additional information below.
Caused by: java.lang.NullPointerException
        at com.gitblit.LdapUserService.setUserAttributes(LdapUserService.java:236)
        at com.gitblit.LdapUserService.authenticate(LdapUserService.java:176)
        at com.gitblit.GitBlit.authenticate(GitBlit.java:473)
        at com.gitblit.wicket.pages.RootPage$1.onSubmit(RootPage.java:131)
        at org.apache.wicket.markup.html.form.Form.delegateSubmit(Form.java:1595)
        at org.apache.wicket.markup.html.form.Form.process(Form.java:960)
        at org.apache.wicket.markup.html.form.Form.onFormSubmitted(Form.java:922)
        ... 25 more


Reported by flaviostutz on 2012-07-17 11:29:54

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Oops.  Fixed on master.

Reported by James.Moger on 2012-07-17 11:45:34

  • Status changed: Queued
  • Labels added: Milestone-1.0.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-08-20 02:06:35

  • Labels added: Milestone-1.1.0
  • Labels removed: Milestone-1.0.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix/change released in 1.1.0.

Reported by James.Moger on 2012-08-25 12:20:42

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.1.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.1.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants