Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartTLS is not supported in LdapUserService #418

Closed
gitblit opened this issue Aug 12, 2015 · 7 comments
Closed

StartTLS is not supported in LdapUserService #418

gitblit opened this issue Aug 12, 2015 · 7 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 122

What steps will reproduce the problem?
1. Have an LDAP server that requires clients to send StartTLS after opening plain text
connection (and not use a SSL connection)
2. Authenticate against such an LDAP server
3. Connection fails, because there's no way to tell GitBlit to send the StartTLS

LdapUserService should call StartTLSExtendedRequest, in case a ldap+tls:// URL is configured,
see https://www.unboundid.com/products/ldapsdk/docs/javadoc/com/unboundid/ldap/sdk/extensions/StartTLSExtendedRequest.html

Reported by steffen@steffen-gebert.de on 2012-08-09 08:51:06

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Thanks for the documentation link.  I assume you require this behavior for your LDAP
server.  I can add in support for this, if you can build from source and test it for
me.

Reported by James.Moger on 2012-08-09 12:32:59

  • Status changed: Accepted

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

I've already a patch.. will do a pull request, soon.

Reported by steffen@steffen-gebert.de on 2012-08-09 12:33:49

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Awesome.

Reported by James.Moger on 2012-08-09 12:42:37

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

https://github.com/gitblit/gitblit/pull/23

Reported by steffen@steffen-gebert.de on 2012-08-09 13:46:55

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-08-09 13:58:45

  • Status changed: Queued
  • Labels added: Milestone-1.0.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-08-20 02:06:35

  • Labels added: Milestone-1.1.0
  • Labels removed: Milestone-1.0.1

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix/change released in 1.1.0.

Reported by James.Moger on 2012-08-25 12:20:42

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.1.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.1.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants