Allow linking to line number on code view #426

Closed
gitblit opened this Issue Aug 12, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 130

What steps will reproduce the problem?
Browse to a file in an repo

What is the expected output? What do you see instead?
Should be able to select a line number to link to that number directly

What version of the product are you using? On what operating system?
1.0.0 on ubuntu 12.04


Reported by lqdinternet on 2012-09-11 11:40:56

@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2012-09-11 20:09:46

  • Status changed: Accepted
  • Labels added: Milestone-1.2.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-09-11 20:09:46

  • Status changed: Accepted
  • Labels added: Milestone-1.2.0
@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
This is mostly completed and live on the demo site.  There is a browser/dom bug which
I am currently seeking help with related to offset from top of the window because it
is currently incorrect by about 50px (the height of the top navbar).

example:
https://demo-gitblit.rhcloud.com/blob/gitblit.git/16e4747d3cb2c2a53a6bef554bca306d8594a080/src!com!gitblit!wicket!pages!BlobPage.java#L1

Reported by James.Moger on 2012-09-14 22:21:04

  • Status changed: Started
Owner

gitblit commented Aug 12, 2015

This is mostly completed and live on the demo site.  There is a browser/dom bug which
I am currently seeking help with related to offset from top of the window because it
is currently incorrect by about 50px (the height of the top navbar).

example:
https://demo-gitblit.rhcloud.com/blob/gitblit.git/16e4747d3cb2c2a53a6bef554bca306d8594a080/src!com!gitblit!wicket!pages!BlobPage.java#L1

Reported by James.Moger on 2012-09-14 22:21:04

  • Status changed: Started
@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
This is now working properly.

https://demo-gitblit.rhcloud.com/blob/gitblit.git/HEAD/src!com!gitblit!wicket!pages!BlobPage.java#L141

Reported by James.Moger on 2012-09-17 15:32:05

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

This is now working properly.

https://demo-gitblit.rhcloud.com/blob/gitblit.git/HEAD/src!com!gitblit!wicket!pages!BlobPage.java#L141

Reported by James.Moger on 2012-09-17 15:32:05

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:25

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:25

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 1.2.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment