Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Charts broken #472

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

Activity Charts broken #472

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 176

Hello,

we converted various cvs projects to git repositories. Due to "issues" during the conversion
some fields contained empty strings or newline chars. This breaks the generated javascript
code in the activity page.

Example Source Code:

...
data_39b7080b.setValue(4, 1, 9.0);
data_39b7080b.setValue(5, 0, '
');
data_39b7080b.setValue(5, 1, 6.0);
...


The problematic code parts are located in GooglePieChart.java and GoogleLineChart.java
in the method "appendChart":

...
this.line(sb, MessageFormat.format("{0}.setValue({1,number,0}, 0, ''{2}'');", dName,
i, value.name));
...

"value.name" must not contain any newline chars !

I am not sure if this can also break other things, we only recognized issues on the
activity page by now.

Best Regards
Daniel



Reported by weird.address on 2012-12-07 11:24:37

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

The issue must be newlines in the author's email address field.  This may get you into
trouble elsewhere - and not just Gitblit.

Reported by James.Moger on 2012-12-07 13:11:39

  • Status changed: Accepted
  • Labels added: Milestone-1.2.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2012-12-07 14:27:13

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

v1.2.0 has been deployed.

Reported by James.Moger on 2013-01-01 01:06:26

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.2.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.2.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants