Fork should use relative file urls #486

Closed
gitblit opened this Issue Aug 12, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 190

A fork'd repo appears to put in an absolute file path in the "origin" field:

file:///mnt/devutil/gitblit/gitblit-1.2.0/../data/git/salsa/core-utils.git


I was expecting this to be a HTTP url of the repo or a relative file path. I'm afraid
of what might happen/break when an upgrade is performed or if the gitblit distribution
is moved to a different place on the filesystem.

Valid concern or just look the other way?

Reported by James.Moger on 2013-01-21 15:27:44

@gitblit gitblit self-assigned this Aug 12, 2015

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-05-23 12:04:06

  • Status changed: Started
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-05-23 12:04:06

  • Status changed: Started
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
URLs are absolute, not relative so we can't use a relative file url.  Because the repository
data folder can be relocated we will have to track fork parent as a field within the
repository config.  This must be noted for those upgrading from 1.2.x.

Reported by James.Moger on 2013-06-13 00:32:50

Owner

gitblit commented Aug 12, 2015

URLs are absolute, not relative so we can't use a relative file url.  Because the repository
data folder can be relocated we will have to track fork parent as a field within the
repository config.  This must be noted for those upgrading from 1.2.x.

Reported by James.Moger on 2013-06-13 00:32:50

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-06-28 20:30:20

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-06-28 20:30:20

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 1.3.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment