sendmail.groovy and sendmail-html.groovy try to mail even if no recipient #497

Closed
gitblit opened this Issue Aug 12, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 201

Currently sendmail.groovy and sendmail-html.groovy try to mail even if no mailinglist
has been set for the repo and no mail.mailinglist has been defined in gitlib.properties.

Perhaps the groovy scripts could check that 'toAddresses' is not empty before composing
the message and sending it. This would save processing time and also avoid the errors
[1] that now appear in the log for such repos.

[1] "ERROR Failed to send message
javax.mail.SendFailedException: No recipient addresses"

Reported by martijnlaan on 2013-02-08 12:19:36

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-02-08 12:48:04

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-02-08 12:48:04

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fixed on master.
Thanks for the report.

Reported by James.Moger on 2013-03-28 21:33:29

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Fixed on master.
Thanks for the report.

Reported by James.Moger on 2013-03-28 21:33:29

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed
Owner

gitblit commented Aug 12, 2015

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this Aug 12, 2015

@fzs fzs modified the milestone: 1.3.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment