New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.gitblit.client.GitblitClient login operation swallows Exceptions #498

Closed
gitblit opened this Issue Aug 12, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 202

What steps will reproduce the problem?
1. Initialize an object of com.gitblit.client.GitblitClient
 and invoke login operation
2. Try to login with invalid credentials

What is the expected output? What do you see instead?
Client recieves no error message, but should return an exception. So seems UnauthorizedExceptions
and some other exceptions are swallowed there.

What version of the product are you using? On what operating system?
API 1.2.1  on Ubuntu 11.10

Please provide any additional information below.


Reported by sajhak on 2013-02-09 20:52:58

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Empty catch blocks should not be there. Have a "throw e" there..

Reported by sajhak on 2013-02-09 21:05:55

Owner

gitblit commented Aug 12, 2015

Empty catch blocks should not be there. Have a "throw e" there..

Reported by sajhak on 2013-02-09 21:05:55

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-02-13 13:06:51

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-02-13 13:06:51

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-05-23 12:07:12

  • Status changed: New
  • Labels removed: Milestone-1.3.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-05-23 12:07:12

  • Status changed: New
  • Labels removed: Milestone-1.3.0

gitblit added a commit that referenced this issue Dec 8, 2015

Merge pull request #979 from pingunaut/master
Remove empty catch blocks to stop swallowing exceptions. #498

@fzs fzs added Status-Fixed and removed Status-New labels Mar 18, 2017

@fzs fzs added this to the 1.8.0 milestone Mar 18, 2017

@fzs

This comment has been minimized.

Show comment
Hide comment
@fzs

fzs Mar 18, 2017

Collaborator

Fixed by PR #979

Collaborator

fzs commented Mar 18, 2017

Fixed by PR #979

@fzs fzs closed this Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment