New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests / Code Review / Patch Sets #511

Closed
gitblit opened this Issue Aug 12, 2015 · 31 comments

Comments

Projects
None yet
3 participants
@gitblit
Owner

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 215

Hi,

Sounds like some great software. I would just like to put in my vote, as mentioned
as an idea on your Roadmap, for pull request capability. I don't think this is asking
for a full-blown social tool, but even for my small team, I'd like for them to only
be able to make tentative pull requests, so I have a chance to review before accepting.

Thanks!

Reported by brettz9 on 2013-03-06 07:11:18

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
What would you define as the minimum feature set necessary for pull requests?

Reported by James.Moger on 2013-03-06 12:56:27

Owner

gitblit commented Aug 12, 2015

What would you define as the minimum feature set necessary for pull requests?

Reported by James.Moger on 2013-03-06 12:56:27

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I think just the ability for a user to submit a pull request from any branch to a given
repo or repo owner, and the ability of the receiving repo owner to view a list of outstanding
pull requests with say a checkbox on each item to indicate which requests can be applied
and auto-closed.

A list of requests viewable by the submitter would certainly be very useful, but even
without that, it would be useful. Messages (whether for proposal, closing, or in the
interim) would be nice, but I think the commit message would be good enough for starters
as users could communicate out of band. Email notifications for new requests and closed
requests would be cool, but again, not critical.

Reported by brettz9 on 2013-03-06 13:16:19

Owner

gitblit commented Aug 12, 2015

I think just the ability for a user to submit a pull request from any branch to a given
repo or repo owner, and the ability of the receiving repo owner to view a list of outstanding
pull requests with say a checkbox on each item to indicate which requests can be applied
and auto-closed.

A list of requests viewable by the submitter would certainly be very useful, but even
without that, it would be useful. Messages (whether for proposal, closing, or in the
interim) would be nice, but I think the commit message would be good enough for starters
as users could communicate out of band. Email notifications for new requests and closed
requests would be cool, but again, not critical.

Reported by brettz9 on 2013-03-06 13:16:19

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Also, with the checkboxes, the ability to dismiss and delete a pull request without
applying.

Reported by brettz9 on 2013-03-06 13:17:53

Owner

gitblit commented Aug 12, 2015

Also, with the checkboxes, the ability to dismiss and delete a pull request without
applying.

Reported by brettz9 on 2013-03-06 13:17:53

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I'm linking to a Google Plus thread which discusses pull requests.
https://plus.google.com/114464678392593421684/posts/Xt3SXpioTK1

And a blog post that pinpoints my complaints about pull requests.
http://julien.danjou.info/blog/2013/rant-about-github-pull-request-workflow-implementation

At the moment, I am leaning towards implementing a simplified Gerrit patchset mechanism
rather than GitHub-style pull requests.

I do have prototype code for both - although my patchsets code is further along.  After
I get the 1.3.0 release out-the-door I can get devote more time to this issue, polish
what I have, and solicit feedback.

Reported by James.Moger on 2013-07-03 15:28:39

Owner

gitblit commented Aug 12, 2015

I'm linking to a Google Plus thread which discusses pull requests.
https://plus.google.com/114464678392593421684/posts/Xt3SXpioTK1

And a blog post that pinpoints my complaints about pull requests.
http://julien.danjou.info/blog/2013/rant-about-github-pull-request-workflow-implementation

At the moment, I am leaning towards implementing a simplified Gerrit patchset mechanism
rather than GitHub-style pull requests.

I do have prototype code for both - although my patchsets code is further along.  After
I get the 1.3.0 release out-the-door I can get devote more time to this issue, polish
what I have, and solicit feedback.

Reported by James.Moger on 2013-07-03 15:28:39

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-07-15 17:36:07

  • Labels added: Milestone-1.4.0
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-07-15 17:36:07

  • Labels added: Milestone-1.4.0
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner

Reported by James.Moger on 2013-07-15 17:36:17

  • Status changed: Started
Owner

gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-07-15 17:36:17

  • Status changed: Started
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Hi, I hope you don't mind me adding my 2p's worth after reading the various discussions...

IMHO I wonder whether the PR and/or PS functionality should not really be in gitblit.
Possibly the ability to do a server-side merge of branches and/or a patch queue for
a branch would be convenient, with an API that allows those functions to be triggered
by an external client. I realise that's very similar to PR and PS but I think there's
a subtle difference. The actual request to "pull" a branch or apply a patch IMO should
be handled outside of the repository manager,I.e email, IM, talking to a colleague,
by whatever means is appropriate for the individuals or business. That means whatever
tools used for code review, auditing, etc. can be used in conjunction with gitblit,
albeit whether it's a manual step at the end of the process to merge the branch or
apply the patch or hopefully that external tool can have a plugin that allows you to
press a button and have that tool invoke that final step on gitblit automatically.


As I see it if PR (a-la github, Atlassian's Stash) or PS (gerrit) are implemented in
gitblit it'll either be a continual battle to keep up feature wise or a duplication
of effort. 

Sorry if I've got the wrong end of the stick and I hope I've made sense. I think gitblit
is fantastic.

Reported by alex.lewis001 on 2013-09-24 17:55:27

Owner

gitblit commented Aug 12, 2015

Hi, I hope you don't mind me adding my 2p's worth after reading the various discussions...

IMHO I wonder whether the PR and/or PS functionality should not really be in gitblit.
Possibly the ability to do a server-side merge of branches and/or a patch queue for
a branch would be convenient, with an API that allows those functions to be triggered
by an external client. I realise that's very similar to PR and PS but I think there's
a subtle difference. The actual request to "pull" a branch or apply a patch IMO should
be handled outside of the repository manager,I.e email, IM, talking to a colleague,
by whatever means is appropriate for the individuals or business. That means whatever
tools used for code review, auditing, etc. can be used in conjunction with gitblit,
albeit whether it's a manual step at the end of the process to merge the branch or
apply the patch or hopefully that external tool can have a plugin that allows you to
press a button and have that tool invoke that final step on gitblit automatically.


As I see it if PR (a-la github, Atlassian's Stash) or PS (gerrit) are implemented in
gitblit it'll either be a continual battle to keep up feature wise or a duplication
of effort. 

Sorry if I've got the wrong end of the stick and I hope I've made sense. I think gitblit
is fantastic.

Reported by alex.lewis001 on 2013-09-24 17:55:27

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Duplication of effort.  For sure it is.  But then so is all of Gitblit or Stash or Gerrit
or GitLab, etc.  They all essentially do the same thing as GitHub, BitBucket, BeanStalk,
whatever.

Gitblit aims to be a complete Git server solution.  That doesn't mean I plan to implement
1:1 what all others offer, but there are some things that I believe are expected of
a server solution: security, repo viewing, repo administration, activity notifications,
etc, and I think a collaboration mechanism (PR or PS or ??) - however primitive - is
on that list.

I think Gitblit should do more to facilitate collaboration and communication _somehow_.
 That doesn't mean this feature must be used by everyone or that everyone is going
to like my particular implementation.  So whenever it lands, it will be optional for
those who want to use other, more-capable, tools like Gerrit or Review Board or a manual
process that works well for them.

Up hill battle.  It already is.  Have you seen the rate that GitHub is adding staff
since the last round of VC funding??  Subscribe to their blog... it seems like 1 a
week.  Wow!  I can't compete with that.  :)

I think I understand your position and I'll keep that use-case in mind as I move forward.
 Thanks for giving this issue some thought.

Reported by James.Moger on 2013-09-24 19:16:03

Owner

gitblit commented Aug 12, 2015

Duplication of effort.  For sure it is.  But then so is all of Gitblit or Stash or Gerrit
or GitLab, etc.  They all essentially do the same thing as GitHub, BitBucket, BeanStalk,
whatever.

Gitblit aims to be a complete Git server solution.  That doesn't mean I plan to implement
1:1 what all others offer, but there are some things that I believe are expected of
a server solution: security, repo viewing, repo administration, activity notifications,
etc, and I think a collaboration mechanism (PR or PS or ??) - however primitive - is
on that list.

I think Gitblit should do more to facilitate collaboration and communication _somehow_.
 That doesn't mean this feature must be used by everyone or that everyone is going
to like my particular implementation.  So whenever it lands, it will be optional for
those who want to use other, more-capable, tools like Gerrit or Review Board or a manual
process that works well for them.

Up hill battle.  It already is.  Have you seen the rate that GitHub is adding staff
since the last round of VC funding??  Subscribe to their blog... it seems like 1 a
week.  Wow!  I can't compete with that.  :)

I think I understand your position and I'll keep that use-case in mind as I move forward.
 Thanks for giving this issue some thought.

Reported by James.Moger on 2013-09-24 19:16:03

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Thanks James for your response. 

To be honest after using GitBlit more aggressively I can see how a collaboration mechanism
is an expected feature. 

Personally I like Pull Requests (I have read the links you posted but I admit I need
to read them again) but maybe that's because they're easier to understand up front,
or more specifically they map better to the way in which I think about the history,
the branches, etc. The patchset mechanism just seems too disconnected from the repository,
but that's just me :)

p.s. Keep up the great work!

Reported by alex.lewis001 on 2013-10-30 18:20:35

Owner

gitblit commented Aug 12, 2015

Thanks James for your response. 

To be honest after using GitBlit more aggressively I can see how a collaboration mechanism
is an expected feature. 

Personally I like Pull Requests (I have read the links you posted but I admit I need
to read them again) but maybe that's because they're easier to understand up front,
or more specifically they map better to the way in which I think about the history,
the branches, etc. The patchset mechanism just seems too disconnected from the repository,
but that's just me :)

p.s. Keep up the great work!

Reported by alex.lewis001 on 2013-10-30 18:20:35

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
First of all: I *love* GitBlit. :)

Second: I'd like to give my vote for PR's. GitHub PR's are nice, but after seeing them
in BitBucket, I think they're great.

And to be honest, Gerrit seems to be overkill for my / our purposes.

Reported by martijn.niji on 2013-11-11 13:06:23

Owner

gitblit commented Aug 12, 2015

First of all: I *love* GitBlit. :)

Second: I'd like to give my vote for PR's. GitHub PR's are nice, but after seeing them
in BitBucket, I think they're great.

And to be honest, Gerrit seems to be overkill for my / our purposes.

Reported by martijn.niji on 2013-11-11 13:06:23

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Another vote from me on my end, this would be a very welcome feature. Gitblit is starting
to become a big thing in our company.

Reported by robindegen on 2013-11-19 10:28:35

Owner

gitblit commented Aug 12, 2015

Another vote from me on my end, this would be a very welcome feature. Gitblit is starting
to become a big thing in our company.

Reported by robindegen on 2013-11-19 10:28:35

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
This feature alone will make our project move to gitblit. Just a simple way to ask for
a pull request would be enough - no need for the social framework, just a notification
that someone has contributed some code and would like it merged to a branch would be
enough.

I have noticed that in the master branch there is some work on this. Is there any idea
of when this feature might be incorporated? If it is soon to be out (even in beta form),
I will probably just deploy gitblit now. Otherwise I'll have to go gitlabs or something
not as good as gitblit.

Thank you so much for this wonderful software. If you have a link to give donations
I would send something. Even more if we could send donations "for this specific feature".

Reported by jsrjenkins on 2013-11-28 11:46:33

Owner

gitblit commented Aug 12, 2015

This feature alone will make our project move to gitblit. Just a simple way to ask for
a pull request would be enough - no need for the social framework, just a notification
that someone has contributed some code and would like it merged to a branch would be
enough.

I have noticed that in the master branch there is some work on this. Is there any idea
of when this feature might be incorporated? If it is soon to be out (even in beta form),
I will probably just deploy gitblit now. Otherwise I'll have to go gitlabs or something
not as good as gitblit.

Thank you so much for this wonderful software. If you have a link to give donations
I would send something. Even more if we could send donations "for this specific feature".

Reported by jsrjenkins on 2013-11-28 11:46:33

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I hope to have a preview of this capability in the next release.  When is the next release?
 Hopefully by the end of December.  I try to aim for 3-4 months between major releases,
with a few point releases as necessary.

What I am working on is a hybrid between Github's pull requests and Gerrit's patchsets.
 The preview will be functional, but incomplete so expect rough edges and missing capabilities.
 I ended up losing several weeks to refactoring the server codebase (landing soon)
and several weeks to a directly related, independent (also rough) project developed
under the umbrella of this feature.

Thanks for your donations offer, but it isn't necessary - this is a passion project
for me.  Maybe you already contribute to some project I regularly use... or maybe your
work will change someone's life for the better.  Either way, pay it forward - I'm doing
alright. :)

Reported by James.Moger on 2013-11-29 02:26:46

Owner

gitblit commented Aug 12, 2015

I hope to have a preview of this capability in the next release.  When is the next release?
 Hopefully by the end of December.  I try to aim for 3-4 months between major releases,
with a few point releases as necessary.

What I am working on is a hybrid between Github's pull requests and Gerrit's patchsets.
 The preview will be functional, but incomplete so expect rough edges and missing capabilities.
 I ended up losing several weeks to refactoring the server codebase (landing soon)
and several weeks to a directly related, independent (also rough) project developed
under the umbrella of this feature.

Thanks for your donations offer, but it isn't necessary - this is a passion project
for me.  Maybe you already contribute to some project I regularly use... or maybe your
work will change someone's life for the better.  Either way, pay it forward - I'm doing
alright. :)

Reported by James.Moger on 2013-11-29 02:26:46

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Hi we are interested in this feature and when will this be available? 

Would love to get an experience on this. Is a trunk or a work in progress version available?

Reported by manisha@wso2.com on 2014-01-02 11:58:05

Owner

gitblit commented Aug 12, 2015

Hi we are interested in this feature and when will this be available? 

Would love to get an experience on this. Is a trunk or a work in progress version available?

Reported by manisha@wso2.com on 2014-01-02 11:58:05

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Is this in the online demo already or only in trunk? I'm very curious to see this "hybrid"
you're talking about. :)

Again: great work on GitBlit!

Reported by martijn.niji on 2014-01-13 14:03:23

Owner

gitblit commented Aug 12, 2015

Is this in the online demo already or only in trunk? I'm very curious to see this "hybrid"
you're talking about. :)

Again: great work on GitBlit!

Reported by martijn.niji on 2014-01-13 14:03:23

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
I've been working very hard on getting this put together for early adopters.
I am very close to sharing - next 7-14 days I hope.  Stay tuned.

Reported by James.Moger on 2014-01-13 14:19:16

Owner

gitblit commented Aug 12, 2015

I've been working very hard on getting this put together for early adopters.
I am very close to sharing - next 7-14 days I hope.  Stay tuned.

Reported by James.Moger on 2014-01-13 14:19:16

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Good news :) I'll see if we can test it internally in our company here.

Reported by robindegen on 2014-01-13 14:25:35

Owner

gitblit commented Aug 12, 2015

Good news :) I'll see if we can test it internally in our company here.

Reported by robindegen on 2014-01-13 14:25:35

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Hi James, 

This is great. 
Is this code committed to trunk/master? Can I find the work in progress code in https://code.google.com/p/gitblit/
so that I can test it with my application?

Thanks

Reported by manisha@wso2.com on 2014-01-16 09:13:15

Owner

gitblit commented Aug 12, 2015

Hi James, 

This is great. 
Is this code committed to trunk/master? Can I find the work in progress code in https://code.google.com/p/gitblit/
so that I can test it with my application?

Thanks

Reported by manisha@wso2.com on 2014-01-16 09:13:15

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Hi Manisha,

Your enthusiasm is noted.  Since it's been 2 days since I wrote that I'd share in the
next 7-14 days, I'll update that and say I'll share within the next 5-12 days. :)

-J

Reported by James.Moger on 2014-01-16 14:16:18

Owner

gitblit commented Aug 12, 2015

Hi Manisha,

Your enthusiasm is noted.  Since it's been 2 days since I wrote that I'd share in the
next 7-14 days, I'll update that and say I'll share within the next 5-12 days. :)

-J

Reported by James.Moger on 2014-01-16 14:16:18

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Hi James, 

I can see the 5-12 days is over by now ;)
Is there a downloadable distribution or a source code available in the repo?

We are eagerly waiting on this feature, which would be extremely useful for us. 

Thanks
Manisha

Reported by manisha@wso2.com on 2014-01-28 04:47:16

Owner

gitblit commented Aug 12, 2015

Hi James, 

I can see the 5-12 days is over by now ;)
Is there a downloadable distribution or a source code available in the repo?

We are eagerly waiting on this feature, which would be extremely useful for us. 

Thanks
Manisha

Reported by manisha@wso2.com on 2014-01-28 04:47:16

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Ok, ok. Pencils down.

<cue ass-kicking, blood-pumping music>

The Tickets feature... (in no particular order)

- is not finished, but is functional
- is not thoroughly tested, but I continuously dogfood it
- is not GitHub issues/pull requests,
  is not BitBucket issues/pull requests,
  is not Gerrit Change Review,
  but does combine aspects of those three with extra flavoring
- is not (yet?) a commit review tool
- is not based on an SQL database
- is focused on commit collaboration, communication, & status workflow
- allows rewriting history AND makes that a first-class feature

This is new and different.  If you've used Gerrit, some of this will seem familiar
although the mechanics are not the same.  If you've never used Gerrit this may seem
alien.  The command-line UI can easily be improved with a simple helper script or tool.
 One was started (mentioned in docs, but is no longer suitable for use - needs redesign).
 A simple Python or Bash wrapper would go a long way here and would be welcome since
in my spare time (hahahaha) I'm trying to learn Python.  :)

This patchset is big.  There are changes in there which need to be split-out into pre-Tickets-patchset
commits because they are tweaks or fixes to some of the rest of the codebase.  I'll
do that in time.

This patchset has cruft (although I've eliminated most).  This code has been rebased,
squashed, and amended several hundred times in the last 8 months.  Still, there are
rough edges, remnants of design iterations, and just ugly shortcuts that need to be
cleaned-up.

If you want to play with it, you'll have to build from source.  If you are or have
been a Gitblit contributor, ping me for an account on this server.  You can help me
dogfood it.

NOTE: I frequently deploy to this server so it may be unavailable from time-to-time,
but it is generally online more reliably than OpenShift. :|

Live instance & current patchset.
https://dev.gitblit.com/tickets/gitblit.git/1

Documentation, such as it is.
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_overview.mkd
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_using.mkd
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_setup.mkd

Reported by James.Moger on 2014-01-28 15:02:09

Owner

gitblit commented Aug 12, 2015

Ok, ok. Pencils down.

<cue ass-kicking, blood-pumping music>

The Tickets feature... (in no particular order)

- is not finished, but is functional
- is not thoroughly tested, but I continuously dogfood it
- is not GitHub issues/pull requests,
  is not BitBucket issues/pull requests,
  is not Gerrit Change Review,
  but does combine aspects of those three with extra flavoring
- is not (yet?) a commit review tool
- is not based on an SQL database
- is focused on commit collaboration, communication, & status workflow
- allows rewriting history AND makes that a first-class feature

This is new and different.  If you've used Gerrit, some of this will seem familiar
although the mechanics are not the same.  If you've never used Gerrit this may seem
alien.  The command-line UI can easily be improved with a simple helper script or tool.
 One was started (mentioned in docs, but is no longer suitable for use - needs redesign).
 A simple Python or Bash wrapper would go a long way here and would be welcome since
in my spare time (hahahaha) I'm trying to learn Python.  :)

This patchset is big.  There are changes in there which need to be split-out into pre-Tickets-patchset
commits because they are tweaks or fixes to some of the rest of the codebase.  I'll
do that in time.

This patchset has cruft (although I've eliminated most).  This code has been rebased,
squashed, and amended several hundred times in the last 8 months.  Still, there are
rough edges, remnants of design iterations, and just ugly shortcuts that need to be
cleaned-up.

If you want to play with it, you'll have to build from source.  If you are or have
been a Gitblit contributor, ping me for an account on this server.  You can help me
dogfood it.

NOTE: I frequently deploy to this server so it may be unavailable from time-to-time,
but it is generally online more reliably than OpenShift. :|

Live instance & current patchset.
https://dev.gitblit.com/tickets/gitblit.git/1

Documentation, such as it is.
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_overview.mkd
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_using.mkd
https://dev.gitblit.com/blob/gitblit.git/refs!tickets!01!1!6/src!site!tickets_setup.mkd

Reported by James.Moger on 2014-01-28 15:02:09

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
James, all I gotta say:

You deserve a medal, dude!

Reported by sundayfunday1234@outlook.com on 2014-01-28 20:41:45

Owner

gitblit commented Aug 12, 2015

James, all I gotta say:

You deserve a medal, dude!

Reported by sundayfunday1234@outlook.com on 2014-01-28 20:41:45

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Very sorry that, as the original poster, I cannot help test, but this sounds like a
very exciting development! Kudos to all your work!

Reported by brettz9 on 2014-01-28 21:08:53

Owner

gitblit commented Aug 12, 2015

Very sorry that, as the original poster, I cannot help test, but this sounds like a
very exciting development! Kudos to all your work!

Reported by brettz9 on 2014-01-28 21:08:53

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
@brettz9: I consider OPs as contributors and I list them in release announcements. 
Your in, if you want.  dev.gitblit.com is my production machine - it's not a playground
although we'll make a playground repo for messing around.  That is my primary motivation
for restricting server access.

Reported by James.Moger on 2014-01-29 13:29:56

Owner

gitblit commented Aug 12, 2015

@brettz9: I consider OPs as contributors and I list them in release announcements. 
Your in, if you want.  dev.gitblit.com is my production machine - it's not a playground
although we'll make a playground repo for messing around.  That is my primary motivation
for restricting server access.

Reported by James.Moger on 2014-01-29 13:29:56

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
This looks good!

I hope to see it in a stable release soon.

Hats off to your work James!

Reported by dharapvj on 2014-01-30 05:07:16

Owner

gitblit commented Aug 12, 2015

This looks good!

I hope to see it in a stable release soon.

Hats off to your work James!

Reported by dharapvj on 2014-01-30 05:07:16

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Thanks for the announcement James. Being busy with some other commitments delayed me
from testing this. 
 Since I am not a GB committer, I will build from source and test this. 
Eager to see the feature. 

Thanks
Manisha

Reported by manisha@wso2.com on 2014-02-05 04:29:49

Owner

gitblit commented Aug 12, 2015

Thanks for the announcement James. Being busy with some other commitments delayed me
from testing this. 
 Since I am not a GB committer, I will build from source and test this. 
Eager to see the feature. 

Thanks
Manisha

Reported by manisha@wso2.com on 2014-02-05 04:29:49

@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
Merged to master.

Reported by James.Moger on 2014-03-04 02:41:36

  • Status changed: Queued
Owner

gitblit commented Aug 12, 2015

Merged to master.

Reported by James.Moger on 2014-03-04 02:41:36

  • Status changed: Queued
@gitblit

This comment has been minimized.

Show comment
Hide comment
@gitblit

gitblit Aug 12, 2015

Owner
1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done
Owner

gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit gitblit closed this Aug 12, 2015

@monkiki

This comment has been minimized.

Show comment
Hide comment
@monkiki

monkiki May 13, 2016

Hello,

Where can I find documentation about this feature. The provided links appear to be down.

monkiki commented May 13, 2016

Hello,

Where can I find documentation about this feature. The provided links appear to be down.

@gitblit

This comment has been minimized.

Show comment
Hide comment
Owner

gitblit commented May 16, 2016

@monkiki

This comment has been minimized.

Show comment
Hide comment
@monkiki

monkiki May 16, 2016

Thanks, I got it.

monkiki commented May 16, 2016

Thanks, I got it.

@fzs fzs modified the milestone: 1.4.0 Dec 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment