Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking View on a Deleted file throws exception #512

Closed
gitblit opened this issue Aug 12, 2015 · 4 comments
Closed

Clicking View on a Deleted file throws exception #512

gitblit opened this issue Aug 12, 2015 · 4 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 216

What steps will reproduce the problem?
1. Open a commit with a deleted file (https://demo-gitblit.rhcloud.com/commit/gitblit.git/11c14e192b907acd3fdc2d6a9bcf4faafc593afe)
2. Click view next to src/com/gitblit/wicket/GitBlitWebApp_pt_br.properties

What is the expected output? What do you see instead?
Unsure of the expected output, since the file doesn't exist...but it shouldn't throw
an exception.  
Maybe disable the ability to click on 'view' or show the last version of the file while
indicating it was deleted.

What version of the product are you using? On what operating system?
1.2.1 (On gitblit demo site)

Please provide any additional information below.
Exception when working locally was (removed repo name and file name):
ERROR Can't instantiate page using constructor public com.gitblit.wicket.pages.BlobPage(org.apache.wicket.PageParameters)
and argument r = "**********" h = "da60ff761bfe307b071d5c3fce0575e9144e3b49" f = "**********"
org.apache.wicket.WicketRuntimeException: Can't instantiate page using constructor
public com.gitblit.wicket.pages.BlobPage(org.apache.wicket.PageParameters) and argument
r = "**********" h = "da60ff761bfe307b071d5c3fce0575e9144e3b49" f = "**********"
        at org.apache.wicket.session.DefaultPageFactory.createPage(DefaultPageFactory.java:212)
        at org.apache.wicket.session.DefaultPageFactory.newPage(DefaultPageFactory.java:89)
        at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.newPage(BookmarkablePageRequestTarget.java:305)
....

Reported by johnedc on 2013-03-07 20:16:41

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Great example.  :)

Reported by James.Moger on 2013-03-07 20:28:11

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Thanks for the report.
Fixed on master.

Reported by James.Moger on 2013-03-29 12:53:14

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Reported by James.Moger on 2013-03-29 13:42:55

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants