Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committer verification always rejecting merges #560

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

Committer verification always rejecting merges #560

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 264

We tried to enable the "verify committer" option in our repositories, but GitBlit stopped
accepting merge commits even when done with the --no-ff option.

If we try to push regular commits they succeed, only merges fail with the "[...] was
not committed by [...]" error.

Please note we're using the LDAP authentication module, not the integrated one.

We're using GitBlit GO 1.2.1 on a Windows Server 2012.

You can find attached an example of the error in a test repository, I'm on the "my-feature"
branch where I just merged the "master" branch, and I'm trying to push the commit.

GitBlit's complaining the commit "Prova" was not done by me, even though I choose to
do a non fast forward merge.

Reported by andrea.bertin on 2013-07-02 16:29:51


- _Attachment: screenshot.png
![screenshot.png](https://storage.googleapis.com/google-code-attachments/gitblit/issue-264/comment-0/screenshot.png)_
@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Huh.  I'm surprised no one else has complained about that.

Reported by James.Moger on 2013-07-02 19:29:12

  • Status changed: Accepted
  • Labels added: Milestone-1.3.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fixed on master.  Your report is timely since I should be releasing 1.3.0 in a few days.

Reported by James.Moger on 2013-07-02 20:53:18

  • Status changed: Queued

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Fix or enhancement released in v1.3.0

Reported by James.Moger on 2013-07-14 16:52:58

  • Status changed: Fixed

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.3.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants