NPE in RepositoryUrlPanel Line 88

[gitblit]

Originally reported on Google Code with ID 269

What steps will reproduce the problem?

Trying to display the summary page of a repo causes a NPE. (All other pages for the
repo worked.)
Checking the code (https://code.google.com/p/gitblit/source/browse/src/main/java/com/gitblit/wicket/panels/RepositoryUrlPanel.java?name=v1.3.0)showed
the obvious error.

primaryUrl = repositoryUrls.size() == 0 ? null : repositoryUrls.get(0);
LINE 88: NPE =>> boolean canClone = ((primaryUrl.permission == null) || primaryUrl.permission.atLeast(AccessPermission.CLONE));

primaryUrl will be null if repositoryUrls.size() == 0 
accessing primaryUrl.permission will throw a NPE.

Reported by RAlfoeldi on 2013-07-15 08:26:57

[gitblit]

Setting 

git.enableGitServlet = false

(probably) causes no urls and the above NPE.

Setting git.enableGitServlet = true "solves" the problem.

As I'm using gitblit only as a git "viewer" this isn't really an option.

Reported by RAlfoeldi on 2013-07-15 08:50:39

[gitblit]

Set at least one url in web.otherUrls

Reported by James.Moger on 2013-07-15 11:53:56

[gitblit]

Fixed on master

Reported by James.Moger on 2013-07-15 12:10:33

• Status changed: Queued
• Labels added: Milestone-1.3.1

[gitblit]

Fix or change deployed in 1.3.1

Reported by James.Moger on 2013-07-24 19:56:32

[gitblit]

Reported by James.Moger on 2013-07-24 19:57:04

• Status changed: Fixed