Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling charts still makes external requests #606

Closed
gitblit opened this issue Aug 12, 2015 · 3 comments
Closed

Disabling charts still makes external requests #606

gitblit opened this issue Aug 12, 2015 · 3 comments

Comments

@gitblit
Copy link
Owner

@gitblit gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 310

What steps will reproduce the problem?
1. Set web.generateActivityGraph = false
2. Observe that graphs are still generated

What is the expected output? What do you see instead?
Graphs are still shown. Graphs should be disabled.

What version of the product are you using? On what operating system?
1.4.0-SNAPSHOT (6de9531)

Please provide any additional information below.
Ideally it'd be nice to generate these graphs without making external requests to a
third party site (and I believe the Charts API is deprecated :().

Reported by chorohoe@wikimedia.org on 2013-09-18 18:31:03

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Setting web.generateActivityGraph DOES disable graphing.  I just re-confirmed.

You might be getting faked-out by use of caching.

Reported by James.Moger on 2013-09-19 12:19:29

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

Ah.  When that setting was created, only the Summary page and the Metrics page had graphs.
 I just pushed a change that makes the Dashboard and Activity pages obey the same setting.
 So I guess we were both right.  :)

As for replacing the charting package... that is a (likely) possibility.  I have gotten
several complaints about wanting to run in an isolated network.  Unfortunately, Google
doesn't allow offline use of their API so I would have to completely replace it.  :(

Reported by James.Moger on 2013-09-19 12:41:29

  • Status changed: Queued
  • Labels added: Milestone-1.4.0

@gitblit
Copy link
Owner Author

@gitblit gitblit commented Aug 12, 2015

1.4.0 released.

Reported by James.Moger on 2014-03-09 18:06:21

  • Status changed: Done

@gitblit gitblit closed this as completed Aug 12, 2015
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
@flaix flaix added this to the 1.4.0 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants